Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve older document upgrading compatibility and make node type errors clearer #2201

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

Keavon
Copy link
Member

@Keavon Keavon commented Jan 16, 2025

@Keavon Keavon force-pushed the doc-upgrading-pre-new-node-macro branch from e75c4be to ebee0c7 Compare January 16, 2025 21:50
@Keavon Keavon marked this pull request as ready for review January 16, 2025 21:50
@Keavon Keavon changed the title Add upgrading support for old nodes changed when introducing the new node macro Improve older document upgrading compatibility and make node type errors clearer Jan 16, 2025
@Keavon Keavon force-pushed the master branch 2 times, most recently from 7465fad to ab724d8 Compare January 18, 2025 00:03
@Keavon
Copy link
Member Author

Keavon commented Jan 19, 2025

Fails to open some of the demo art, more investigation needed.

@Keavon Keavon marked this pull request as draft January 19, 2025 04:05
@Keavon Keavon force-pushed the doc-upgrading-pre-new-node-macro branch from 66749a7 to cf055fd Compare January 21, 2025 08:25
@Keavon Keavon marked this pull request as ready for review January 21, 2025 08:27
@Keavon Keavon merged commit 8505ed3 into master Jan 21, 2025
5 checks passed
@Keavon Keavon deleted the doc-upgrading-pre-new-node-macro branch January 21, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant