Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection history navigation with Alt+[ and Alt+] keys should filter out empty selections #2136

Closed

Conversation

0SlowPoke0
Copy link
Contributor

filters empty selections made by select tool before adding in the selection history

@0HyperCube 0HyperCube changed the title Filtering empty selections Selection history navigation with Alt+[ and Alt+] keys should filter out empty selections Dec 12, 2024
@0HyperCube 0HyperCube marked this pull request as ready for review December 12, 2024 20:25
@0HyperCube 0HyperCube force-pushed the filtering_empty_selections branch from 80c02d3 to 3a3704f Compare December 12, 2024 20:26
@0HyperCube 0HyperCube marked this pull request as draft December 12, 2024 21:14
@0HyperCube 0HyperCube marked this pull request as ready for review December 16, 2024 18:33
@0HyperCube 0HyperCube force-pushed the filtering_empty_selections branch 3 times, most recently from d321cf0 to 6c38f72 Compare December 16, 2024 18:36
Copy link
Member

@0HyperCube 0HyperCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix; it appears to work as expected (although perhaps @Keavon will want to check as well).

@Keavon Keavon force-pushed the filtering_empty_selections branch from d322704 to af9d3ae Compare December 17, 2024 07:09
@Keavon
Copy link
Member

Keavon commented Dec 17, 2024

@0SlowPoke0 @0HyperCube can you both please confirm that my simplification commit c362e26 is indeed equivalent? I don't understand why it was so complicated before, and I'm pretty sure the changes I made are correct, but I'm asking to make sure I didn't miss any subtleties that explained why the previous code was so complicated.

Edit: Oh, my bad, it was to satisfy the borrow checker. I didn't actually confirm my simplifications compiled, whoops.

@Keavon
Copy link
Member

Keavon commented Dec 17, 2024

!build

Copy link

📦 Build Complete for dd88eba
https://de6a16bf.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Dec 17, 2024

This PR breaks the editor (unable to draw more shapes, unable to select layers, etc.) after you've drawn the first shape. This was the case since 5427956, the most recent commit by @0SlowPoke0 (rather than commits from Hypercube and me).

@Keavon Keavon marked this pull request as draft December 17, 2024 20:38
@0SlowPoke0 0SlowPoke0 force-pushed the filtering_empty_selections branch from cb3804c to 9dafb91 Compare December 19, 2024 14:11
@0SlowPoke0
Copy link
Contributor Author

@Keavon , can you please make a build for testing, thanks !

@Keavon
Copy link
Member

Keavon commented Dec 19, 2024

!build

Copy link

📦 Build Complete for 9dafb91
https://7eb6e77d.graphite.pages.dev

@0SlowPoke0
Copy link
Contributor Author

@Keavon I think this solves the issue can you please review the build, thanks.

@Keavon
Copy link
Member

Keavon commented Dec 21, 2024

Superseded by #2138

@Keavon Keavon closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants