-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selection history navigation with Alt+[ and Alt+] keys should filter out empty selections #2136
Selection history navigation with Alt+[ and Alt+] keys should filter out empty selections #2136
Conversation
80c02d3
to
3a3704f
Compare
d321cf0
to
6c38f72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix; it appears to work as expected (although perhaps @Keavon will want to check as well).
6c38f72
to
d322704
Compare
d322704
to
af9d3ae
Compare
@0SlowPoke0 @0HyperCube can you both please confirm that my simplification commit c362e26 is indeed equivalent? I don't understand why it was so complicated before, and I'm pretty sure the changes I made are correct, but I'm asking to make sure I didn't miss any subtleties that explained why the previous code was so complicated. Edit: Oh, my bad, it was to satisfy the borrow checker. I didn't actually confirm my simplifications compiled, whoops. |
!build |
|
This PR breaks the editor (unable to draw more shapes, unable to select layers, etc.) after you've drawn the first shape. This was the case since 5427956, the most recent commit by @0SlowPoke0 (rather than commits from Hypercube and me). |
cb3804c
to
9dafb91
Compare
@Keavon , can you please make a build for testing, thanks ! |
!build |
|
@Keavon I think this solves the issue can you please review the build, thanks. |
Superseded by #2138 |
filters empty selections made by select tool before adding in the selection history