Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor in artboard clipping to the click target x-ray function #2028

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

0HyperCube
Copy link
Member

As requested by @Keavon.

I chose to implement collecting the clipping artboards as part of collecting the metadata. If @adamgerhant wishes to redo this then they are welcome to.

@adamgerhant
Copy link
Collaborator

I think using the render output is good for now until there is better monitor node insertion for the artboard data.

Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully! And that's some nice abstraction, I like it!

@Keavon Keavon changed the title Add clipping to the click xray function Factor in artboard clipping to the click target x-ray function Oct 12, 2024
@Keavon Keavon enabled auto-merge (squash) October 12, 2024 23:28
@Keavon Keavon merged commit d6f46f7 into master Oct 12, 2024
4 checks passed
@Keavon Keavon deleted the click-xray-clipping branch October 12, 2024 23:38
@adamgerhant adamgerhant mentioned this pull request Oct 14, 2024
Keavon added a commit that referenced this pull request Oct 14, 2024
…2036)

* Fix me crashing the editor due to not paying attention

* Swap two lines for consistency

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants