Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unbound result variable in SlimChannelConverter #232

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

clari7744
Copy link
Contributor

result was moved inside an if statement in SlimChannelConverter, causing it to be unbound if ctx.guild is None

Rationale

Bugfix, that's all

Summary of changes made

Set result to None before the first if statement

Checklist

  • This PR changes the jishaku module/cog codebase
    • These changes add new functionality to the module/cog
    • These changes fix an issue or bug in the module/cog
    • I have tested that these changes work on a production bot codebase
    • I have tested these changes against the CI/CD test suite
    • I have updated the documentation to reflect these changes
  • This PR changes the CI/CD test suite
    • I have tested my suite changes are well-formed (all tests can be discovered)
    • These changes adjust existing test cases
    • These changes add new test cases
  • This PR changes prose (such as the documentation, README or other Markdown/RST documents)
    • I have proofread my changes for grammar and spelling issues
    • I have tested that any changes regarding Markdown/RST syntax result in a well formed document

…using it to be unbound if ctx.guild is None
@Gorialis
Copy link
Owner

regression introduced by #221

@Gorialis Gorialis merged commit 5189eaf into Gorialis:master Apr 25, 2024
31 checks passed
@clari7744 clari7744 deleted the fix-slimchannel-unbound branch April 25, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants