-
Notifications
You must be signed in to change notification settings - Fork 179
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Video Cropping: Add post meta for original (#12349)
Co-authored-by: Pascal Birchler <pascalb@google.com>
- Loading branch information
1 parent
8b61ff5
commit c07eccc
Showing
11 changed files
with
200 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| <?php | ||
| /** | ||
| * Class Cropping | ||
| * | ||
| * @link https://github.com/googleforcreators/web-stories-wp | ||
| * | ||
| * @copyright 2022 Google LLC | ||
| * @license https://www.apache.org/licenses/LICENSE-2.0 Apache License 2.0 | ||
| */ | ||
|
|
||
| /** | ||
| * Copyright 2022 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| namespace Google\Web_Stories\Media; | ||
|
|
||
| use Google\Web_Stories\Infrastructure\HasMeta; | ||
| use Google\Web_Stories\Service_Base; | ||
|
|
||
| /** | ||
| * Class Cropping | ||
| */ | ||
| class Cropping extends Service_Base implements HasMeta { | ||
|
|
||
| /** | ||
| * The cropped video id post meta key. | ||
| */ | ||
| public const CROPPED_ID_POST_META_KEY = 'web_stories_cropped_origin_id'; | ||
|
|
||
| /** | ||
| * Init. | ||
| * | ||
| * @since 1.26.0 | ||
| */ | ||
| public function register(): void { | ||
| $this->register_meta(); | ||
| add_action( 'delete_attachment', [ $this, 'delete_video' ] ); | ||
| } | ||
|
|
||
| /** | ||
| * Register meta | ||
| * | ||
| * @since 1.26.0 | ||
| */ | ||
| public function register_meta(): void { | ||
| register_meta( | ||
| 'post', | ||
| self::CROPPED_ID_POST_META_KEY, | ||
| [ | ||
| 'sanitize_callback' => 'absint', | ||
| 'type' => 'integer', | ||
| 'description' => __( 'Parent ID if this is a cropped attachment', 'web-stories' ), | ||
| 'show_in_rest' => true, | ||
| 'default' => 0, | ||
| 'single' => true, | ||
| 'object_subtype' => 'attachment', | ||
| ] | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Deletes associated meta data when a video is deleted. | ||
| * | ||
| * @since 1.26.0 | ||
| * | ||
| * @param int $attachment_id ID of the attachment to be deleted. | ||
| */ | ||
| public function delete_video( int $attachment_id ): void { | ||
| delete_metadata( 'post', 0, self::CROPPED_ID_POST_META_KEY, $attachment_id, true ); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| <?php | ||
| /** | ||
| * Copyright 2022 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| namespace Google\Web_Stories\Tests\Integration\Media; | ||
|
|
||
| use Google\Web_Stories\Tests\Integration\TestCase; | ||
|
|
||
| /** | ||
| * @coversDefaultClass \Google\Web_Stories\Media\Cropping | ||
| */ | ||
| class Cropping extends TestCase { | ||
| /** | ||
| * Test instance. | ||
| * | ||
| * @var \Google\Web_Stories\Media\Cropping | ||
| */ | ||
| protected $instance; | ||
|
|
||
| public function set_up(): void { | ||
| parent::set_up(); | ||
|
|
||
| $this->instance = new \Google\Web_Stories\Media\Cropping(); | ||
| } | ||
|
|
||
| /** | ||
| * @covers ::register | ||
| */ | ||
| public function test_register(): void { | ||
| $this->instance->register(); | ||
|
|
||
| $this->assertTrue( registered_meta_key_exists( 'post', $this->instance::CROPPED_ID_POST_META_KEY, 'attachment' ) ); | ||
| $this->assertSame( 10, has_action( 'delete_attachment', [ $this->instance, 'delete_video' ] ) ); | ||
| } | ||
|
|
||
| /** | ||
| * @covers ::delete_video | ||
| */ | ||
| public function test_delete_video_meta_attachment_is_deleted(): void { | ||
| $video_attachment_id = self::factory()->attachment->create_object( | ||
| [ | ||
| 'file' => DIR_TESTDATA . '/uploads/test-video.mp4', | ||
| 'post_parent' => 0, | ||
| 'post_mime_type' => 'video/mp4', | ||
| 'post_title' => 'Test Video', | ||
| ] | ||
| ); | ||
|
|
||
| $cropped_attachment_id = self::factory()->attachment->create_object( | ||
| [ | ||
| 'file' => DIR_TESTDATA . '/uploads/test-video.mp4', | ||
| 'post_parent' => 0, | ||
| 'post_mime_type' => 'image/jpeg', | ||
| 'post_title' => 'Test Image', | ||
| ] | ||
| ); | ||
|
|
||
| add_post_meta( $video_attachment_id, $this->instance::CROPPED_ID_POST_META_KEY, $cropped_attachment_id ); | ||
| $this->assertSame( $cropped_attachment_id, (int) get_post_meta( $video_attachment_id, $this->instance::CROPPED_ID_POST_META_KEY, true ) ); | ||
| wp_delete_attachment( $cropped_attachment_id ); | ||
| $this->assertEmpty( get_post_meta( $video_attachment_id, $this->instance::CROPPED_ID_POST_META_KEY, true ) ); | ||
| } | ||
| } |
Oops, something went wrong.