Update puppeteer / fix tests (#13895)

GoogleForCreators · Jan 6, 2025 · b6b826c · b6b826c
1 parent 40dc434
commit b6b826c
Show file tree

Hide file tree

Showing 40 changed files with 1,303 additions and 623 deletions.
diff --git a/.github/workflows/tests-e2e.yml b/.github/workflows/tests-e2e.yml
@@ -193,6 +193,11 @@ jobs:
           COMPOSE_INTERACTIVE_NO_CLI: true
           WP_VERSION: ${{ matrix.wp }}
 
+      # See https://issues.chromium.org/issues/373753919
+      # and https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md
+      - name: Disable AppArmor
+        run: echo 0 | sudo tee /proc/sys/kernel/apparmor_restrict_unprivileged_userns
+
       - name: Get Chromium executable path
         id: chromium_path
         run: |

diff --git a/.github/workflows/tests-karma-dashboard.yml b/.github/workflows/tests-karma-dashboard.yml
@@ -81,6 +81,11 @@ jobs:
         env:
           PUPPETEER_PRODUCT: chrome
 
+      # See https://issues.chromium.org/issues/373753919
+      # and https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md
+      - name: Disable AppArmor
+        run: echo 0 | sudo tee /proc/sys/kernel/apparmor_restrict_unprivileged_userns
+
       # FIXME: https://github.com/googleforcreators/web-stories-wp/issues/4364
       - name: Increase max number of file watchers
         run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
@@ -99,6 +104,6 @@ jobs:
       - name: Upload code coverage report
         uses: codecov/codecov-action@1e68e06f1dbfde0e4cefc87efeba9e4643565303
         with:
-          file: build/logs/karma-coverage/dashboard/lcov.info
+          files: build/logs/karma-coverage/dashboard/lcov.info
           flags: karmatests
           token: ${{ secrets.CODECOV_TOKEN }}
diff --git a/.github/workflows/tests-karma-editor.yml b/.github/workflows/tests-karma-editor.yml
@@ -119,6 +119,11 @@ jobs:
         env:
           PUPPETEER_PRODUCT: chrome
 
+      # See https://issues.chromium.org/issues/373753919
+      # and https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md
+      - name: Disable AppArmor
+        run: echo 0 | sudo tee /proc/sys/kernel/apparmor_restrict_unprivileged_userns
+
       # FIXME: https://github.com/googleforcreators/web-stories-wp/issues/4364
       - name: Increase max number of file watchers
         run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
@@ -140,6 +145,6 @@ jobs:
       - name: Upload code coverage report
         uses: codecov/codecov-action@1e68e06f1dbfde0e4cefc87efeba9e4643565303
         with:
-          file: build/logs/karma-coverage/story-editor/lcov.info
+          files: build/logs/karma-coverage/story-editor/lcov.info
           flags: karmatests
           token: ${{ secrets.CODECOV_TOKEN }}
diff --git a/.github/workflows/tests-unit-js.yml b/.github/workflows/tests-unit-js.yml
@@ -105,6 +105,6 @@ jobs:
       - name: Upload code coverage report
         uses: codecov/codecov-action@1e68e06f1dbfde0e4cefc87efeba9e4643565303
         with:
-          file: build/logs/lcov.info
+          files: build/logs/lcov.info
           flags: unittests
           token: ${{ secrets.CODECOV_TOKEN }}
diff --git a/.github/workflows/tests-unit-php.yml b/.github/workflows/tests-unit-php.yml
@@ -185,6 +185,6 @@ jobs:
       - name: Upload code coverage report
         uses: codecov/codecov-action@1e68e06f1dbfde0e4cefc87efeba9e4643565303
         with:
-          file: build/logs/*.xml
+          files: build/logs/*.xml
           token: ${{ secrets.CODECOV_TOKEN }}
         if: ${{ matrix.coverage }}
diff --git a/jest-puppeteer.config.cjs b/jest-puppeteer.config.cjs
@@ -19,15 +19,15 @@
  */
 const {
   PUPPETEER_DEVTOOLS = false,
-  PUPPETEER_HEADLESS = 'new',
+  PUPPETEER_HEADLESS = true,
   PUPPETEER_PRODUCT = 'chrome',
   PUPPETEER_SLOWMO = 0,
 } = process.env;
 
 module.exports = {
   launch: {
     devtools: PUPPETEER_DEVTOOLS === 'true',
-    headless: PUPPETEER_HEADLESS !== 'false' ? PUPPETEER_HEADLESS : false,
+    headless: Boolean(PUPPETEER_HEADLESS),
     slowMo: Number(PUPPETEER_SLOWMO) || 0,
     product: PUPPETEER_PRODUCT,
     args: ['--window-size=1600,1000'], // Same as in percy.config.yml.

diff --git a/karma-dashboard.config.cjs b/karma-dashboard.config.cjs
@@ -131,7 +131,7 @@ module.exports = function (config) {
 
     puppeteerLauncher: {
       puppeteer: {
-        headless: config.headless ? 'new' : false,
+        headless: Boolean(config.headless),
         slowMo: config.slowMo || 0,
         devtools: config.devtools || false,
         snapshots: config.snapshots || false,

diff --git a/karma-story-editor.config.cjs b/karma-story-editor.config.cjs
@@ -143,7 +143,7 @@ module.exports = function (config) {
 
     puppeteerLauncher: {
       puppeteer: {
-        headless: config.headless ? 'new' : false,
+        headless: Boolean(config.headless),
         slowMo: config.slowMo || 0,
         devtools: config.devtools || false,
         snapshots: config.snapshots || false,