From 825b1258cbd757dd2754df17f16a4e06fd5a5473 Mon Sep 17 00:00:00 2001 From: Pascal Birchler Date: Wed, 22 Jan 2025 09:35:14 +0100 Subject: [PATCH] Fix some incorrect css values --- .../app/views/myStories/content/storyGridItem/components.js | 1 - packages/dashboard/src/components/table/index.js | 3 ++- packages/design-system/src/components/button/stories/index.js | 1 - .../story-editor/src/components/canvas/mediaCaptions/cue.js | 2 +- .../src/components/footer/carousel/carouselList.js | 1 - .../story-editor/src/components/footer/gridview/gridView.js | 1 - .../src/components/panels/design/alignment/alignment.js | 1 - .../story-editor/src/components/panels/panel/shared/title.js | 1 - packages/story-editor/src/components/sidebar/sidebarContent.js | 2 +- packages/story-editor/src/components/thumbnail/styles.js | 2 +- 10 files changed, 5 insertions(+), 10 deletions(-) diff --git a/packages/dashboard/src/app/views/myStories/content/storyGridItem/components.js b/packages/dashboard/src/app/views/myStories/content/storyGridItem/components.js index e8a2127239f8..63d26f82f3bd 100644 --- a/packages/dashboard/src/app/views/myStories/content/storyGridItem/components.js +++ b/packages/dashboard/src/app/views/myStories/content/storyGridItem/components.js @@ -92,7 +92,6 @@ export const CardDetailsGrid = styled.div` `; export const CardDetailsColumn = styled.div` display: flex; - align-items: space-between; flex-direction: column; align-self: flex-end; `; diff --git a/packages/dashboard/src/components/table/index.js b/packages/dashboard/src/components/table/index.js index 59a289c184e1..eeed6abc6083 100644 --- a/packages/dashboard/src/components/table/index.js +++ b/packages/dashboard/src/components/table/index.js @@ -119,7 +119,8 @@ export const TableRow = styled.tr` export const TableCell = styled.td` padding: ${CELL_PADDING}px; font-weight: normal; - word-break: break-word; + overflow-wrap: anywhere; + word-break: normal; height: ${CELL_PADDING * 2 + 50}px; vertical-align: middle; diff --git a/packages/design-system/src/components/button/stories/index.js b/packages/design-system/src/components/button/stories/index.js index d258baa18a45..3810817955c8 100644 --- a/packages/design-system/src/components/button/stories/index.js +++ b/packages/design-system/src/components/button/stories/index.js @@ -60,7 +60,6 @@ const Container = styled.div` border: 1px solid ${(props) => props.theme.colors.fg.black}; display: flex; - align-items: space-evenly; flex-direction: column; padding: 20px; `; diff --git a/packages/story-editor/src/components/canvas/mediaCaptions/cue.js b/packages/story-editor/src/components/canvas/mediaCaptions/cue.js index 1a92c1ef951a..a19e703b1ccb 100644 --- a/packages/story-editor/src/components/canvas/mediaCaptions/cue.js +++ b/packages/story-editor/src/components/canvas/mediaCaptions/cue.js @@ -45,7 +45,7 @@ const Section = styled.span` font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen-Sans, Ubuntu, Cantarell, 'Helvetica Neue', sans-serif; line-height: 1.4; - word-break: break-word; + word-break: normal; word-wrap: break-word; overflow-wrap: break-word; `; diff --git a/packages/story-editor/src/components/footer/carousel/carouselList.js b/packages/story-editor/src/components/footer/carousel/carouselList.js index a944ee1e3d28..6c4fb9c54ba7 100644 --- a/packages/story-editor/src/components/footer/carousel/carouselList.js +++ b/packages/story-editor/src/components/footer/carousel/carouselList.js @@ -48,7 +48,6 @@ const PageList = styled(Reorderable).attrs({ hasOverflow && css` overflow-x: visible; - overflow-x: overlay; justify-content: flex-start; `}; diff --git a/packages/story-editor/src/components/footer/gridview/gridView.js b/packages/story-editor/src/components/footer/gridview/gridView.js index ea9802e755ce..be5ab934204a 100644 --- a/packages/story-editor/src/components/footer/gridview/gridView.js +++ b/packages/story-editor/src/components/footer/gridview/gridView.js @@ -76,7 +76,6 @@ const TopRow = styled.header` const Wrapper = styled(Reorderable)` position: relative; overflow-y: auto; - overflow-y: overlay; overflow-x: hidden; flex-grow: 1; display: flex; diff --git a/packages/story-editor/src/components/panels/design/alignment/alignment.js b/packages/story-editor/src/components/panels/design/alignment/alignment.js index a78e7d78448b..2c4beb527ed8 100644 --- a/packages/story-editor/src/components/panels/design/alignment/alignment.js +++ b/packages/story-editor/src/components/panels/design/alignment/alignment.js @@ -46,7 +46,6 @@ const ElementRow = styled.div` align-items: center; padding: 16px; overflow: auto; - overflow: overlay; `; const alignmentButtonIds = [ diff --git a/packages/story-editor/src/components/panels/panel/shared/title.js b/packages/story-editor/src/components/panels/panel/shared/title.js index 9d14a9d45406..2ca3b0019ee7 100644 --- a/packages/story-editor/src/components/panels/panel/shared/title.js +++ b/packages/story-editor/src/components/panels/panel/shared/title.js @@ -62,7 +62,6 @@ const Heading = styled.span` color: ${({ theme, isCollapsed }) => isCollapsed ? theme.colors.fg.secondary : theme.colors.fg.primary}; display: flex; - align-items: space-between; ${({ theme }) => themeHelpers.expandPresetStyles({ preset: theme.typography.presets.headline[TextSize.XXSmall], diff --git a/packages/story-editor/src/components/sidebar/sidebarContent.js b/packages/story-editor/src/components/sidebar/sidebarContent.js index d5edb998a56b..8732048168a7 100644 --- a/packages/story-editor/src/components/sidebar/sidebarContent.js +++ b/packages/story-editor/src/components/sidebar/sidebarContent.js @@ -26,7 +26,7 @@ import { getTabId } from './utils'; const SidebarPane = styled.div.attrs({ role: 'tabpanel' })` height: 100%; - overflow: overlay; + overflow: auto; `; const SidebarPanes = styled.section` diff --git a/packages/story-editor/src/components/thumbnail/styles.js b/packages/story-editor/src/components/thumbnail/styles.js index 883a7c54121e..f6dac7453bce 100644 --- a/packages/story-editor/src/components/thumbnail/styles.js +++ b/packages/story-editor/src/components/thumbnail/styles.js @@ -147,7 +147,7 @@ export const Background = styled.div( css` /* Specific overrides for PagePreview that is borrowed for checklist's thumbnails */ .pagePreviewOverrides { - border-color: none; + border-color: transparent; &::after { content: none;