feat: Add mockgcp tests for ApigeeInstance #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwenma
reviewed
Feb 4, 2025
| @@ -40,5 +40,5 @@ status: | |||
| lastModifiedAt: 1711974896 | |||
| port: "443" | |||
| runtimeVersion: 1-14-0-apigee-4 | |||
| serviceAttachment: projects/eef779b38d9fb4b50p-tp/regions/us-central1/serviceAttachments/apigee-us-central1-i9mj | |||
| serviceAttachment: projects/${projectIDd)/regions/us-central1/serviceAttachments/apigee-us-central1-abcd | |||
There was a problem hiding this comment.
Good catch, fixed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jasonvigil
force-pushed
the
apigee-instance-mocks
branch
from
a550041 to
c8b90b2
Compare
jasonvigil
force-pushed
the
apigee-instance-mocks
branch
from
c8b90b2 to
c4625de
Compare
|
Seems like this is blocked on a failing test ( |
jasonvigil
force-pushed
the
apigee-instance-mocks
branch
from
c4625de to
44aceab
Compare
|
Ok, rebased now that #3600 is merged. |
|
/lgtm cc @jingyih |
google-oss-prow
bot
merged commit 73c23a1
into
GoogleCloudPlatform:master
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.