mockgcp: support for workflows #3584
Conversation
justinsb
commented
Feb 1, 2025
•
justinsb
commented
- mockgcp: add test case for workflows workflow
- mockgcp: support for workflows
- mockgcp: generate bindings for workflows.v1
- mockgcp: capture golden output for workflow test
- tests: don't require header on any testdata files
There was a problem hiding this comment.
Do we want to check in this file (and the next one)?
There was a problem hiding this comment.
Yes, they are referenced from script.yaml
| @@ -121,6 +121,8 @@ func (p *Proxy) BuildGcloudConfig(proxyEndpoint *net.TCPAddr, mockgcp mockgcp.In | |||
| "storage.googleapis.com", | |||
| "cloudresourcemanager.googleapis.com", | |||
| "serviceusage.googleapis.com", | |||
| "workflows.googleapis.com", | |||
| "workflowexecutions.googleapis.com", | |||
There was a problem hiding this comment.
Cool! Is this added by AI via some hints like "update the service in proxy.go" or manually added?
There was a problem hiding this comment.
I think I manually added these, but yes it would be easy enough to ask AI to add them automatically. I guess one gotcha is that we don't actually know the service names at this stage (until we've run the test).
Maybe we should just add all the hostnames we know of (or at least the ones that gcloud knows of!)
There might also be a better way to intercept gcloud traffic, I just haven't found one yet!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
force-pushed
the
mockgcp_workflows_support
branch
from
1692f79 to
45048f7
Compare
|
New changes are detected. LGTM label has been removed. |
Headers make it difficult to do generation and string-matching.
justinsb
force-pushed
the
mockgcp_workflows_support
branch
from
45048f7 to
56f4c67
Compare
