-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(modelarmor): Added snippets for get floor settings #5281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(modelarmor): Added snippets for get floor settings #5281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tirthrajsinh-zala-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds code samples for retrieving floor settings in the Model Armor API for different resource scopes: project, folder, and organization. It includes three new Go files, each demonstrating how to get the floor settings for a specific scope. Additionally, it adds a new module for modelarmor and updates the go.work
file to include the new module. The pull request also includes a test file with tests for the new code samples.
Highlights
- New code samples: Added three new Go files (
get_project_floor_settings.go
,get_organization_floor_settings.go
, andget_folder_floor_settings.go
) demonstrating how to retrieve floor settings for project, organization and folder scopes respectively. - Module creation: Created a new Go module for modelarmor, including
go.mod
andgo.sum
files to manage dependencies. - Integration: Updated the
go.work
file to include the new modelarmor module in the workspace. - Testing: Added a test file (
modelarmor_test.go
) with tests for the new code samples, ensuring they function as expected.
Changelog
Click here to see the changelog
- go.work
- Added the
./modelarmor
module to the workspace.
- Added the
- modelarmor/get_folder_floor_settings.go
- Created a new file with a function
getFolderFloorSettings
to retrieve floor settings for a folder. - Includes example usage and error handling.
- Created a new file with a function
- modelarmor/get_organization_floor_settings.go
- Created a new file with a function
getOrganizationFloorSettings
to retrieve floor settings for an organization. - Includes example usage and error handling.
- Created a new file with a function
- modelarmor/get_project_floor_settings.go
- Created a new file with a function
getProjectFloorSettings
to retrieve floor settings for a project. - Includes example usage and error handling.
- Created a new file with a function
- modelarmor/go.mod
- Created a new
go.mod
file to define the module and its dependencies, includingcloud.google.com/go/modelarmor
and other necessary modules.
- Created a new
- modelarmor/go.sum
- Created a new
go.sum
file to track the dependencies of the module.
- Created a new
- modelarmor/modelarmor_test.go
- Created a new test file with tests for
getProjectFloorSettings
,getOrganizationFloorSettings
, andgetFolderFloorSettings
. - Uses
testutil
andgodotenv
for testing and environment variable loading.
- Created a new test file with tests for
- modelarmor/quickstart/quickstart.go
- Created a quickstart sample that shows how to create a template and sanitize user prompts and model responses.
- modelarmor/testdata/env/test.env
- Created a test environment file that contains the organization and folder ID for testing.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A floor setting's gentle grace,
Guiding models, finding their place.
In project's keep,
Or folder's sleep,
Responsible AI we embrace.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adds code samples for retrieving floor settings for projects, folders, and organizations using the Model Armor API. The code includes functions to retrieve these settings and corresponding tests. A quickstart example is also provided to demonstrate basic usage of the API.
Merge Readiness
The pull request introduces new code samples and tests for the Model Armor API. Given the absence of any critical or high severity issues, the pull request appears to be in good shape to be merged, but I would recommend addressing the medium severity issues first. However, I am unable to directly approve the pull request, and users should have others review and approve this code before merging.
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has the same global issues as #5273 . Please re-open once all issues have been addressed.
Description
Added modelarmor code samples for get floor settings
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)