Skip to content

feat(modelarmor): Added snippets for get floor settings #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

tirthrajsinh-zala-crest
Copy link
Contributor

@tirthrajsinh-zala-crest tirthrajsinh-zala-crest commented Apr 11, 2025

Description

Added modelarmor code samples for get floor settings

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (Model Armor API)
  • These samples need a new/updated env vars in testing projects set to pass ()
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 11, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tirthrajsinh-zala-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request adds code samples for retrieving floor settings in the Model Armor API for different resource scopes: project, folder, and organization. It includes three new Go files, each demonstrating how to get the floor settings for a specific scope. Additionally, it adds a new module for modelarmor and updates the go.work file to include the new module. The pull request also includes a test file with tests for the new code samples.

Highlights

  • New code samples: Added three new Go files (get_project_floor_settings.go, get_organization_floor_settings.go, and get_folder_floor_settings.go) demonstrating how to retrieve floor settings for project, organization and folder scopes respectively.
  • Module creation: Created a new Go module for modelarmor, including go.mod and go.sum files to manage dependencies.
  • Integration: Updated the go.work file to include the new modelarmor module in the workspace.
  • Testing: Added a test file (modelarmor_test.go) with tests for the new code samples, ensuring they function as expected.

Changelog

Click here to see the changelog
  • go.work
    • Added the ./modelarmor module to the workspace.
  • modelarmor/get_folder_floor_settings.go
    • Created a new file with a function getFolderFloorSettings to retrieve floor settings for a folder.
    • Includes example usage and error handling.
  • modelarmor/get_organization_floor_settings.go
    • Created a new file with a function getOrganizationFloorSettings to retrieve floor settings for an organization.
    • Includes example usage and error handling.
  • modelarmor/get_project_floor_settings.go
    • Created a new file with a function getProjectFloorSettings to retrieve floor settings for a project.
    • Includes example usage and error handling.
  • modelarmor/go.mod
    • Created a new go.mod file to define the module and its dependencies, including cloud.google.com/go/modelarmor and other necessary modules.
  • modelarmor/go.sum
    • Created a new go.sum file to track the dependencies of the module.
  • modelarmor/modelarmor_test.go
    • Created a new test file with tests for getProjectFloorSettings, getOrganizationFloorSettings, and getFolderFloorSettings.
    • Uses testutil and godotenv for testing and environment variable loading.
  • modelarmor/quickstart/quickstart.go
    • Created a quickstart sample that shows how to create a template and sanitize user prompts and model responses.
  • modelarmor/testdata/env/test.env
    • Created a test environment file that contains the organization and folder ID for testing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A floor setting's gentle grace,
Guiding models, finding their place.
In project's keep,
Or folder's sleep,
Responsible AI we embrace.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds code samples for retrieving floor settings for projects, folders, and organizations using the Model Armor API. The code includes functions to retrieve these settings and corresponding tests. A quickstart example is also provided to demonstrate basic usage of the API.

Merge Readiness

The pull request introduces new code samples and tests for the Model Armor API. Given the absence of any critical or high severity issues, the pull request appears to be in good shape to be merged, but I would recommend addressing the medium severity issues first. However, I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

@tirthrajsinh-zala-crest tirthrajsinh-zala-crest marked this pull request as ready for review April 11, 2025 13:28
@tirthrajsinh-zala-crest tirthrajsinh-zala-crest requested review from a team as code owners April 11, 2025 13:28
Copy link

snippet-bot bot commented Apr 11, 2025

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Collaborator

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has the same global issues as #5273 . Please re-open once all issues have been addressed.

@telpirion telpirion self-assigned this Apr 11, 2025
@telpirion telpirion marked this pull request as draft April 11, 2025 18:38
@tirthrajsinh-zala-crest tirthrajsinh-zala-crest marked this pull request as ready for review April 14, 2025 17:34
@tirthrajsinh-zala-crest tirthrajsinh-zala-crest changed the title feat(modelarmor): Added modelarmor code samples for get floor settings feat(modelarmor): Added snippet for get floor settings Apr 17, 2025
@tirthrajsinh-zala-crest tirthrajsinh-zala-crest changed the title feat(modelarmor): Added snippet for get floor settings feat(modelarmor): Added snippets for get floor settings Apr 17, 2025
@tirthrajsinh-zala-crest tirthrajsinh-zala-crest requested a review from a team as a code owner April 18, 2025 10:25
@product-auto-label product-auto-label bot added the api: modelarmor Issues related to the Model Armor API. label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: modelarmor Issues related to the Model Armor API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants