BQ: Fix substitutions schema (#66)

Fixed bug introduced by #65 . * fix substitution struct bug * add inferschema test * address pr comments
GoogleCloudPlatform · Aug 11, 2020 · 95eaa62 · 95eaa62
1 parent 7c39f4f
commit 95eaa62
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/bigquery/main.go b/bigquery/main.go
@@ -74,7 +74,12 @@ type bqRow struct {
 	Tags           []string
 	Env            []string
 	LogURL         string
-	Substitutions  [][]string
+	Substitutions  []*substitution
+}
+
+type substitution struct {
+	Key   string
+	Value string
 }
 
 type buildImage struct {
@@ -255,9 +260,9 @@ func (n *bqNotifier) SendNotification(ctx context.Context, build *cbpb.Build) er
 	if err != nil {
 		return fmt.Errorf("Error generating UTM params: %v", err)
 	}
-	substitutions := [][]string{}
+	substitutions := []*substitution{}
 	for key, value := range build.Substitutions {
-		substitutions = append(substitutions, []string{key, value})
+		substitutions = append(substitutions, &substitution{key, value})
 	}
 	newRow := &bqRow{
 		ProjectID:      build.ProjectId,

diff --git a/bigquery/main_test.go b/bigquery/main_test.go
@@ -622,3 +622,9 @@ func TestGetImageSize(t *testing.T) {
 		})
 	}
 }
+
+func TestInferSchema(t *testing.T) {
+	if _, err := bigquery.InferSchema(bqRow{}); err != nil {
+		t.Errorf("Failed to infer schema: %v", err)
+	}
+}