Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description of Pub/Sub subscription parameter #2135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VeronicaWasson
Copy link

@VeronicaWasson VeronicaWasson commented Jan 15, 2025

Bug Fix - See b/390088746

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.72%. Comparing base (31f6239) to head (ae47dcf).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2135      +/-   ##
============================================
- Coverage     50.78%   46.72%   -4.07%     
- Complexity     1606     4302    +2696     
============================================
  Files           444      872     +428     
  Lines         23755    51688   +27933     
  Branches       2325     5402    +3077     
============================================
+ Hits          12065    24151   +12086     
- Misses        10990    25818   +14828     
- Partials        700     1719    +1019     
Components Coverage Δ
spanner-templates 68.79% <ø> (-1.54%) ⬇️
spanner-import-export 65.57% <ø> (∅)
spanner-live-forward-migration 77.51% <ø> (ø)
spanner-live-reverse-replication 78.39% <ø> (ø)
spanner-bulk-migration 87.87% <ø> (ø)

see 445 files with indirect coverage changes

@VeronicaWasson VeronicaWasson force-pushed the PubsubCommonOptions_parameter_description branch from 883e03e to ae47dcf Compare January 17, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant