MongoDbToBigQuery - ISO standard for date and time #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abacn
reviewed
Jan 22, 2025
| @@ -119,7 +141,8 @@ public static Document getMongoDbDocument(String uri, String dbName, String coll | |||
| return doc; | |||
| } | |||
|
|
|||
| public static TableRow getTableSchema(Document document, String userOption) { | |||
| public static TableRow getTableSchema( | |||
There was a problem hiding this comment.
Could you please add a unit test for legacy / iso time format?
| order = 2, | ||
| optional = true, | ||
| description = "Use legacy time format.", | ||
| helpText = |
There was a problem hiding this comment.
The description is "use legacy time format" but the option name is "useIsoTimeFormat". The helpText (default is true) is also not true. Please fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed that the format of dates and timestamp are broken, compared to the mongodb fields, e.g. a date appears as "Mar 12, 2024, 3:05:34 AM", instead of the original ISO format
This PR fixes the issue, thanks !