Spanner Import/Export INTERLEAVE IN #2128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite/read the type to/from avro. No change to tests yet.
…oDdlConverter. Also properly default to IN PARENT when emitting ddl, in case the interleave type is not set (really only necessary for tests, since otherwise it will always be set.
darshan-sj
reviewed
Jan 23, 2025
v1/src/main/java/com/google/cloud/teleport/spanner/DdlToAvroSchemaConverter.java
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/spanner/ddl/InformationSchemaScanner.java
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/spanner/ddl/InformationSchemaScanner.java
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/spanner/ddl/InformationSchemaScanner.java
Outdated
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/spanner/ddl/InformationSchemaScanner.java
Outdated
Show resolved
Hide resolved
darshan-sj
previously approved these changes
Jan 24, 2025
darshan-sj
reviewed
Jan 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2128 +/- ##
============================================
+ Coverage 46.88% 46.90% +0.01%
- Complexity 4011 4018 +7
============================================
Files 874 874
Lines 52042 52054 +12
Branches 5454 5459 +5
============================================
+ Hits 24398 24414 +16
+ Misses 25902 25901 -1
+ Partials 1742 1739 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Import/Export of Spanner
INTERLEAVE INtables. This new feature allows for omitting thePARENTkeyword inCREATE/ALTER <table> INTERLEAVE IN [PARENT] <parent_table>clauses.INTERLEAVE INtables are similar toINTERLEAVE IN PARENT, but do not enforce parent/child referential integrity.INTERLEAVE INtables do not supportON DELETEactions.I manually verified this works by creating a table with two children, one
INTERLEAVE INand the otherINTERLEAVE IN PARENT. All tables had a few rows - and theINTERLEAVE INtable contained a row for which the parent row was missing.I exported this db to avro using these instructuons, and imported to an empty db following these. I manually checked the target db contained the correct tables and rows, and also verified the entries in the
INFORMATION_SCHEMA.Tableswere identical across both tables (specifically theINTERLEAVE_TYPE,PARENT_TABLE_NAME, andON_DELETE_ACTIONcolumns)