[Reverse Replication] Adding load test for custom transformation #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2061 +/- ##
==========================================
Coverage 46.87% 46.87%
- Complexity 4009 4336 +327
==========================================
Files 874 874
Lines 52038 52042 +4
Branches 5453 5454 +1
==========================================
+ Hits 24393 24397 +4
+ Misses 25905 25904 -1
- Partials 1740 1741 +1
|
darshan-sj
approved these changes
Jan 3, 2025
| MigrationTransformationResponse response = | ||
| new MigrationTransformationResponse(responseRow, false); | ||
| return response; | ||
| } else if (request.getTableName().equals("Person")) { |
There was a problem hiding this comment.
Can you add a todo and probably create a bug to rename this file? Looks like we are reusing this for Reverse replication Load tests, so the name should not contain ForLive and IT suffix.
| } | ||
|
|
||
| @Test | ||
| public void reverseReplication1KTpsLoadTest() |
There was a problem hiding this comment.
Please change the method name to contain context of full test case. reverseReplication1KTpsWithCustomTransformation maybe?
| private final String spannerDdlResource = "SpannerToMySqlSourceLT/spanner-schema.sql"; | ||
| private final String sessionFileResource = "SpannerToMySqlCustomTransformationLT/session.json"; | ||
| private final String dataGeneratorSchemaResource = | ||
| "SpannerToMySqlSourceLT/datagenerator-schema.json"; |
There was a problem hiding this comment.
Do you not need a new datagenerator-schema?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.