Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical CRS download fails on "Cheatsheet" documentation page #646

Open
rhugonnet opened this issue Nov 12, 2024 · 2 comments · Fixed by #666
Open

Vertical CRS download fails on "Cheatsheet" documentation page #646

rhugonnet opened this issue Nov 12, 2024 · 2 comments · Fixed by #666
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@rhugonnet
Copy link
Member

Only fails on ReadTheDocs (works fine locally), and only on that page. It also works on the "Vertical referencing" page on the ReadTheDocs, even though it uses the same transformation... 🤯

I tested a few thing (copy/pasting transformation of the "Vertical referencing" page, changing vertical CRS), without success...

@rhugonnet
Copy link
Member Author

Finally found more on this mysterious issue: The downloading only fails for the first notebook executed by Readthedocs that calls DEM.to_vcrs() (Reminder: it works fine locally).
By default, this is alphabetical, so cheatsheet.md fails. If I rename it into something starting with "z", it's instead the dem_class.md that fails. And then vertical_ref.md.
I'm trying to circumvent by a trick for now, adding an occurence of to_vcrs() in a fully hidden cell of biascorr.md (the first notebook to be executed).
If that works, I'll merge the temporary fix like this.

@rhugonnet
Copy link
Member Author

rhugonnet commented Dec 7, 2024

The temporary fix in #666 works but is not ideal (adds useless code to biascorr.md, might break if we add a new page that executes before alphabetically), so re-opening this to keep track of it.

@rhugonnet rhugonnet reopened this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant