Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default fit_sum_model_variogram can overfit short ranges #613

Open
rhugonnet opened this issue Oct 23, 2024 · 2 comments
Open

Default fit_sum_model_variogram can overfit short ranges #613

rhugonnet opened this issue Oct 23, 2024 · 2 comments
Labels
enhancement Feature improvement or request

Comments

@rhugonnet
Copy link
Member

See for example fit below, courtesy of Julian Llanto:
Screenshot from 2024-10-23 15-33-02

We should better adapt default arguments, maybe prevent a range shorter than X times the resolution?
And prevent a fit within X times that of another range? (by some iterative process re-doing the fit several times and adjusting the bounds?)
Not sure what the most robust method would be here 🤔.

@rhugonnet rhugonnet added the enhancement Feature improvement or request label Oct 23, 2024
@erikmannerfelt
Copy link
Contributor

For the moment, would it be possible to define threshold for when it becomes a problem and then trigger a warning if someone tries anyway?

@rhugonnet
Copy link
Member Author

It doesn't seem to happen so often from what I hear... so maybe we can leave as is for now, until we add an enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature improvement or request
Projects
None yet
Development

No branches or pull requests

2 participants