Skip to content
This repository has been archived by the owner on Apr 21, 2020. It is now read-only.

CI - More aggressive caching for Drupal and NPM #105

Merged
merged 35 commits into from
Jun 6, 2017
Merged

Conversation

AronNovak
Copy link
Member

@AronNovak AronNovak commented May 12, 2017

Status

Started to think about the structure

Todo:

  • cache Drupal source (except custom modules)
  • cache NPM installs
  • add invalidation logic
  • tests

will fix #103

@AronNovak
Copy link
Member Author

AronNovak commented May 22, 2017

I spent 5.25 hours on this issue so far, i still have a little remaining, but likely i will run out of time here. The only thing left however is to debug. At local, using Docker Compose, I could trigger the cache use, and it worked, on Travis, it fails, it says some modules are missing, so somehow the content of the cache is unusable. Apart from this, what was planned was implemented, for both Drupal and NPM.
//cc @amitaibu

@AronNovak
Copy link
Member Author

  for FILE in $(git ls-files --others -i --exclude-standard)
  do  
    cp --parents "$FILE" "$TRAVIS_CACHE_DIR"/www_ignored
  done

Tested at local Docker execution, this part is not yet effective, debugging to be continued.
ci-scripts/docker_files/post_cache.sh

@AronNovak
Copy link
Member Author

The caching itself works, i cannot tell the exact numbers, but i expected a bit better improvement of execution speed.
I wanted to invite our @gizra-robot friend to post a video, as many things were changed, but waiting for zalando/zalenium#131 to be able to continue.

@gizra-robot
Copy link

  • Video of the failed WebdriverIO test login.

@AronNovak AronNovak changed the title WIP: CI - More aggressive caching for Drupal and NPM CI - More aggressive caching for Drupal and NPM May 31, 2017
@AronNovak AronNovak requested a review from amitaibu June 6, 2017 06:26
@AronNovak
Copy link
Member Author

Ready for review. The speed gain will be likely even more for real-world projects based on Elm Starter, where the drush si is slower for instance.

@AronNovak
Copy link
Member Author

may1

@amitaibu amitaibu merged commit 23fbd0f into master Jun 6, 2017
@amitaibu
Copy link
Member

amitaibu commented Jun 6, 2017

Lovely!

@amitaibu amitaibu deleted the 103-travis-cache branch June 6, 2017 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speedup builds by caching data [8h]
3 participants