Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Barrels cause glitchy behavior #5328

Open
rrgeorge opened this issue Feb 10, 2025 · 4 comments
Open

Barrels cause glitchy behavior #5328

rrgeorge opened this issue Feb 10, 2025 · 4 comments
Assignees
@onebeastchris

Comments

@rrgeorge
Copy link

Describe the bug

It seems that the latest commit b96f915 to use barrels causes some strange behavior interacting with barrels.

To Reproduce

  1. Place a barrel
  2. Put some items in it
  3. Remove some items
  4. Try combining or separating stacks of items

Expected behaviour

To be have the same as a chest

Screenshots / Videos

See video showing normal behavior with a chest, and glitchy behavior with a barrel:
(github will not accept my upload, so here's a discord link: )

Server Version and Plugins

  • minecraft server version 1.21.4
  • NeoForge mod loading, version 21.4.88-beta, for MC 1.21.4
  • Geyser version 2.6.0-b756 (git-master-b96f915) (Java: 1.21.4, Bedrock: 1.21.40 - 1.21.44 - 1.21.50 - 1.21.51)
    • ThirdPartyCosmetics
    • MCXboxBroadcast
  • Mod List:
    • adventure-platform-neoforge 6.2.0 (adventure_platform_neoforge)
    • Anvil Restoration 2.3 (anvilrestoration)
    • Balm 21.4.11 (balm)
    • Cloud Command Framework 2.0.0-beta.10 (cloud)
    • Collective 7.89 (collective)
    • Crying Portals 2.8 (cryingportals)
    • Cycle Paintings 3.6 (cyclepaintings)
    • Double Doors 6.0 (doubledoors)
    • Easy Elevators 1.2 (easyelevators)
    • Eroding Stone Entities 4.6 (erodingstoneentities)
    • Floodgate 2.2.4-SNAPSHOT (floodgate)
    • Followers Teleport Too 2.6 (followersteleporttoo)
    • Hurricane 2.1.0 (hurricane)
    • KumaAPI 21.4.5 (kuma_api)
    • Mineral Chance 3.7 (mineralchance)
    • Nether Portal Spread 8.3 (netherportalspread)
    • NetherPortalFix 21.4.1 (netherportalfix)
    • Snowballs Freeze Mobs 3.7 (snowballsfreezemobs)
    • squaremap 1.3.4 (squaremap)
    • Teleport Commands 1.2.2 (teleport_commands)
    • Welcome Message 2.6 (welcomemessage)
    • WITS 1.4.0+1.21.3-neoforge (wits)

Geyser Dump

https://dump.geysermc.org/LM6YgmEgWfpVAUZoRR0woqppMbMGHPZ9

Geyser Version

2.6.0-b756 (git-master-b96f915)

Minecraft: Bedrock Edition Device/Version

1.21.51, iPadOS

Additional Context

No response
@onebeastchris onebeastchris self-assigned this Feb 13, 2025
@rrgeorge
Copy link
Author

Debug log when glitch happens:

Feb 16 09:08:42 prometheus java[1572537]: [09:08:42] [Geyser player thread-5-1/ERROR] [geyser/]: DEBUG: About to reject TAKE/PLACE request made by rrgeorge01
Feb 16 09:08:42 prometheus java[1572537]: [09:08:42] [Geyser player thread-5-1/ERROR] [geyser/]: Source: ItemStackRequestSlotData(container=CURSOR, slot=0, stackNetworkId=66, containerName=FullContainerName(container=CURSOR, dynamicId=null)) Result: true
Feb 16 09:08:42 prometheus java[1572537]: [09:08:42] [Geyser player thread-5-1/ERROR] [geyser/]: Destination: ItemStackRequestSlotData(container=BARREL, slot=8, stackNetworkId=51, containerName=FullContainerName(container=BARREL, dynamicId=null)) Result: false
Feb 16 09:08:42 prometheus java[1572537]: [09:08:42] [Geyser player thread-5-1/ERROR] [geyser/]: Geyser's record of source slot: GeyserItemStack(javaId=252, amount=34, components=null, netId=43, bundleData=null, item=Item{javaIdentifier='minecraft:sugar_cane', javaId=252})
Feb 16 09:08:42 prometheus java[1572537]: [09:08:42] [Geyser player thread-5-1/ERROR] [geyser/]: Geyser's record of destination slot: GeyserItemStack(javaId=0, amount=0, components=null, netId=0, bundleData=null, item=null)
Feb 16 09:08:42 prometheus java[1572537]: java.lang.Throwable: DEBUGGING: ItemStackRequest rejected ItemStackRequest(requestId=-5, actions=[PlaceAction(count=24, source=ItemStackRequestSlotData(container=CURSOR, slot=0, stackNetworkId=66, containerName=FullContainerName(container=CURSOR, dynamicId=null)), destination=ItemStackRequestSlotData(container=BARREL, slot=8, stackNetworkId=51, containerName=FullContainerName(container=BARREL, dynamicId=null)))], filterStrings=[], textProcessingEventOrigin=null)
Feb 16 09:08:42 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.translator.inventory.InventoryTranslator.rejectRequest(InventoryTranslator.java:918)
Feb 16 09:08:42 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.translator.inventory.InventoryTranslator.rejectRequest(InventoryTranslator.java:907)
Feb 16 09:08:42 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.translator.inventory.InventoryTranslator.translateRequest(InventoryTranslator.java:243)
Feb 16 09:08:42 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.translator.inventory.InventoryTranslator.translateRequests(InventoryTranslator.java:201)
Feb 16 09:08:42 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.translator.protocol.bedrock.BedrockItemStackRequestTranslator.translate(BedrockItemStackRequestTranslator.java:48)
Feb 16 09:08:42 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.translator.protocol.bedrock.BedrockItemStackRequestTranslator.translate(BedrockItemStackRequestTranslator.java:38)
Feb 16 09:08:42 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.registry.PacketTranslatorRegistry.translate0(PacketTranslatorRegistry.java:92)
Feb 16 09:08:42 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.registry.PacketTranslatorRegistry.lambda$translate$0(PacketTranslatorRegistry.java:72)
Feb 16 09:08:42 prometheus java[1572537]:         at MC-BOOTSTRAP/io.netty.common@4.1.115.Final/io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173)
Feb 16 09:08:42 prometheus java[1572537]:         at MC-BOOTSTRAP/io.netty.transport@4.1.115.Final/io.netty.channel.DefaultEventLoop.run(DefaultEventLoop.java:54)
Feb 16 09:08:42 prometheus java[1572537]:         at MC-BOOTSTRAP/io.netty.common@4.1.115.Final/io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
Feb 16 09:08:42 prometheus java[1572537]:         at MC-BOOTSTRAP/io.netty.common@4.1.115.Final/io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
Feb 16 09:08:42 prometheus java[1572537]:         at MC-BOOTSTRAP/io.netty.common@4.1.115.Final/io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
Feb 16 09:08:42 prometheus java[1572537]:         at java.base/java.lang.Thread.run(Thread.java:1583)
Feb 16 09:08:46 prometheus java[1572537]: [09:08:46] [Geyser player thread-5-1/ERROR] [geyser/]: DEBUG: About to reject TAKE/PLACE request made by rrgeorge01
Feb 16 09:08:46 prometheus java[1572537]: [09:08:46] [Geyser player thread-5-1/ERROR] [geyser/]: Source: ItemStackRequestSlotData(container=CURSOR, slot=0, stackNetworkId=72, containerName=FullContainerName(container=CURSOR, dynamicId=null)) Result: true
Feb 16 09:08:46 prometheus java[1572537]: [09:08:46] [Geyser player thread-5-1/ERROR] [geyser/]: Destination: ItemStackRequestSlotData(container=BARREL, slot=8, stackNetworkId=0, containerName=FullContainerName(container=BARREL, dynamicId=null)) Result: false
Feb 16 09:08:46 prometheus java[1572537]: [09:08:46] [Geyser player thread-5-1/ERROR] [geyser/]: Geyser's record of source slot: GeyserItemStack(javaId=252, amount=34, components=null, netId=43, bundleData=null, item=Item{javaIdentifier='minecraft:sugar_cane', javaId=252})
Feb 16 09:08:46 prometheus java[1572537]: [09:08:46] [Geyser player thread-5-1/ERROR] [geyser/]: Geyser's record of destination slot: GeyserItemStack(javaId=373, amount=6, components=null, netId=71, bundleData=null, item=Item{javaIdentifier='minecraft:melon', javaId=373})
Feb 16 09:08:46 prometheus java[1572537]: java.lang.Throwable: DEBUGGING: ItemStackRequest rejected ItemStackRequest(requestId=-19, actions=[PlaceAction(count=34, source=ItemStackRequestSlotData(container=CURSOR, slot=0, stackNetworkId=72, containerName=FullContainerName(container=CURSOR, dynamicId=null)), destination=ItemStackRequestSlotData(container=BARREL, slot=8, stackNetworkId=0, containerName=FullContainerName(container=BARREL, dynamicId=null)))], filterStrings=[], textProcessingEventOrigin=null)
Feb 16 09:08:46 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.translator.inventory.InventoryTranslator.rejectRequest(InventoryTranslator.java:918)
Feb 16 09:08:46 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.translator.inventory.InventoryTranslator.rejectRequest(InventoryTranslator.java:907)
Feb 16 09:08:46 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.translator.inventory.InventoryTranslator.translateRequest(InventoryTranslator.java:243)
Feb 16 09:08:46 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.translator.inventory.InventoryTranslator.translateRequests(InventoryTranslator.java:201)
Feb 16 09:08:46 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.translator.protocol.bedrock.BedrockItemStackRequestTranslator.translate(BedrockItemStackRequestTranslator.java:48)
Feb 16 09:08:46 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.translator.protocol.bedrock.BedrockItemStackRequestTranslator.translate(BedrockItemStackRequestTranslator.java:38)
Feb 16 09:08:46 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.registry.PacketTranslatorRegistry.translate0(PacketTranslatorRegistry.java:92)
Feb 16 09:08:46 prometheus java[1572537]:         at TRANSFORMER/geyser_neoforge@2.6.1-SNAPSHOT/org.geysermc.geyser.registry.PacketTranslatorRegistry.lambda$translate$0(PacketTranslatorRegistry.java:72)
Feb 16 09:08:46 prometheus java[1572537]:         at MC-BOOTSTRAP/io.netty.common@4.1.115.Final/io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173)
Feb 16 09:08:46 prometheus java[1572537]:         at MC-BOOTSTRAP/io.netty.transport@4.1.115.Final/io.netty.channel.DefaultEventLoop.run(DefaultEventLoop.java:54)
Feb 16 09:08:46 prometheus java[1572537]:         at MC-BOOTSTRAP/io.netty.common@4.1.115.Final/io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
Feb 16 09:08:46 prometheus java[1572537]:         at MC-BOOTSTRAP/io.netty.common@4.1.115.Final/io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
Feb 16 09:08:46 prometheus java[1572537]:         at MC-BOOTSTRAP/io.netty.common@4.1.115.Final/io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
Feb 16 09:08:46 prometheus java[1572537]:         at java.base/java.lang.Thread.run(Thread.java:1583)

@onebeastchris
Copy link
Member

Interesting, I'm not able to reproduce this issue with Bedrock edition on Win10. I'm further unsure how the linked commit would even be able to trigger this...

Can you test whenever this happens with touch input as opposed to controller input? Further, are any other containers affected similar to this one?

@rrgeorge
Copy link
Author

Interesting, I'm not able to reproduce this issue with Bedrock edition on Win10. I'm further unsure how the linked commit would even be able to trigger this...

Can you test whenever this happens with touch input as opposed to controller input? Further, are any other containers affected similar to this one?

Same behavior using touch mode instead of keyboard and mouse. And it doesn't happen with any other containers (tested with chests and shulker boxes)
The reason I suggested that that commit is related, is because it says it switches to using barrels instead of using a fake chest workaround.

@LOURENT4462
Copy link

LOURENT4462 commented Feb 18, 2025 •
edited
Loading

I have same issue on my server
You can check this video https://vioo.cc/v/32VE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onebeastchris onebeastchris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rrgeorge @LOURENT4462 @onebeastchris