Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]Misleading error logs when leaving a call #658

Merged
merged 1 commit into from
Feb 5, 2025
Merged

[Fix]Misleading error logs when leaving a call #658

merged 1 commit into from
Feb 5, 2025

Conversation

ipavlidakis
Copy link
Collaborator

📝 Summary

By checking if the webSocket task is active we ensure that we only process the events (and messages) that really can be processed.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis added bug Something isn't working enhancement New feature or request labels Feb 5, 2025
@ipavlidakis ipavlidakis self-assigned this Feb 5, 2025
@ipavlidakis ipavlidakis requested a review from a team as a code owner February 5, 2025 12:35
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamVideo 7.46 MB 7.46 MB 0 KB 🟢
StreamVideoSwiftUI 2.07 MB 2.07 MB 0 KB 🟢
StreamVideoUIKit 2.21 MB 2.21 MB 0 KB 🟢
StreamWebRTC 9.85 MB 9.85 MB 0 KB 🟢

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ipavlidakis ipavlidakis merged commit 61623a9 into develop Feb 5, 2025
14 checks passed
@ipavlidakis ipavlidakis deleted the fix/error-logs-when-leaving-a-call branch February 5, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski