Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Closed Captions support and docs #643

Merged
merged 5 commits into from
Jan 30, 2025
Merged

[Feature]Closed Captions support and docs #643

merged 5 commits into from
Jan 30, 2025

Conversation

ipavlidakis
Copy link
Collaborator

🔗 Issue Links

https://linear.app/stream/issue/IOS-498/spec-and-cookbook-for-closed-captions-cc

📝 Summary

Implement API to consume and control ClosedCaptions.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • [] Changelog is updated with client-facing changes
  • x ] New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Jan 28, 2025
@ipavlidakis ipavlidakis self-assigned this Jan 28, 2025
@ipavlidakis ipavlidakis requested a review from a team as a code owner January 28, 2025 17:45
@github-actions GitHub Actions
Copy link

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jan 28, 2025 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.38 MB 7.42 MB +43 KB 🟢
StreamVideoSwiftUI 2.07 MB 2.07 MB 0 KB 🟢
StreamVideoUIKit 2.21 MB 2.21 MB 0 KB 🟢
StreamWebRTC 9.85 MB 9.85 MB 0 KB 🟢

martinmitrevski
martinmitrevski reviewed Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just couple of small things. Also, we need to disable it by default in the demo app.

DemoApp/Sources/ViewModifiers/MoreControls/DemoTranscriptionAndClosedCaptionsButtonView.swift Show resolved Hide resolved
DemoApp/Sources/Views/ClosedCaptionsView/DemoClosedCaptionsView.swift Outdated Show resolved Hide resolved
Sources/StreamVideo/Call.swift Outdated Show resolved Hide resolved
Sources/StreamVideo/Utils/ClosedCaptionsAdapter/ClosedCaptionsAdapter.swift Show resolved Hide resolved
Sources/StreamVideo/Utils/OrderedCapacityQueue/OrderedCapacityQueue.swift Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
149 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.3% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarQube Cloud

@ipavlidakis ipavlidakis enabled auto-merge (squash) January 29, 2025 17:01
@ipavlidakis ipavlidakis disabled auto-merge January 30, 2025 09:24
@ipavlidakis ipavlidakis merged commit 04ac104 into develop Jan 30, 2025
10 of 11 checks passed
@ipavlidakis ipavlidakis deleted the feature/closed-captions branch January 30, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski