-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented fast reconnection #235
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There a few more points from the Spec that Android is handling and seems that we don't.
- They seem to be handling differently the WS disconnection and the Internet connection dropping (reference)
- When trying to fully reconnect they are trying for up to 30 seconds and then they fail. Shall we also do that (probably as part of another PR)?
I tried connecting to another wifi (the guest network of my main one) but didn't manage to get the onto the fast reconnect path
Kudos, SonarCloud Quality Gate passed! |
🎯 Goal
Implement fast reconnect on iOS. Fast reconnect means you try to re-join without leaving the call. Other users will notice a brief freeze of you.
Check the spec on notion for more details.
🛠 Implementation
Mostly updated the WebRTC client.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
img
img
🧪 Manual Testing Notes
It's a bit tricky to test, and the success of fast reconnect depends on many factors.
However, what's important is - even if fast reconnect fails, there's a full reconnect as a fallback.
Testing steps:
☑️ Contributor Checklist
🎁 Meme