-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROM Properties page displays incorrectly with StartAllBack installed #399
Comments
+1 |
…StartAllBack installed. See #399: ROM Properties page displays incorrectly with StartAllBack installed Reported by @kristibektashi. Updated RP_ShellPropSheetExt and RP_XAttrView with this change. FIXME: - "Warning" colors aren't working. The text shows up as black. - The "Options" button has black text in Dark mode. - In "Light" mode, the dialog background color looks "off". Maybe only do the forwarding if "Dark" mode is enabled? - Need to force a refresh if the color scheme changes?
Please test the DLLs in this build (once it finishes): https://ci.appveyor.com/project/GerbilSoft/rom-properties/builds/48949174/job/yuae38ythykwmx91 The main fix was forwarding WM_CTLCOLOR* messages to the parent dialog. StartAllBack intercepts those messages and remaps them for use with its enhanced dark mode functionality. Some stuff still isn't working right now:
I'll note that the tab background color still isn't quite right. (It's too dark compared to other tabs.) I'll need to do some more investigation into figuring that out. |
When you install StartAllBack and enable dark mode in the settings, the File Explorer properties dialogs also show in dark mode. However this causes issues with the Rom Properties page where some parts are still bright and the text is unreadable.
The text was updated successfully, but these errors were encountered: