Change term request issue to GitHub form #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@turbomam you gave an original approval on this, could you read add for until we get the final OK for consistency |
only1chunts
reviewed
Dec 2, 2024
| attributes: | ||
| label: Example | ||
| description: > | ||
| An example value for the term/slot |
There was a problem hiding this comment.
should we extend this description to include "the example value must follow the pattern/syntax described above."
turbomam
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
I approve, pending a resolution to @only1chunts suggestion about "the example value must follow the pattern/syntax described above."
jfy133
commented
Dec 4, 2024
|
@only1chunts done! Please give ✅ of you're happy and I can merge |
only1chunts
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR due to a mangled branch on my fork.
Please see the original discussion here.