-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace string serialisation with enum for HostSex categories #849
Conversation
see also which includes more repairs along the same lines, but also introduces excessive formatting changes I recommend merging this as soon as possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent first contribution to mixs.yaml
@turbomam what is the merging protocol here, may I do this when I have an approval? Or do I lead it to a senior project member? |
Thanks, removing @jfy133 thanks for your contribution. I don't think you need any one senior person to approve this, but the decision to merge is usually made live, during a TWG or CIG meeting on Tuesday. I will advocate for this, but posting in the GSC slack and adding an agenda item to either or both of the meetings notes files will help prioritize your PR |
Great thank you! I can't attend the CIG meeting but I've left an agenda point anyway |
Thanks @jfy133. The LinkML implementation here is the ideal outcome. @pbuttigieg points out that the composition of this enumeration is a case of semantic injection @mslarae13 points out that the description includes the word "gender" @turbomam will dig up the NCBI values for this and other sex and gender terms/slots Do we need to split this out into biological sex and gender terms? We should include out sources in the LinkML model. @pbuttigieg found this visual for exploring the societal and chromosomal bases of sex and gender. Might not have enough emphasis on developmental outcome of producing gametes of a particular type. |
Ideal outcome: two clearly distinguished terms
|
https://en.m.wikipedia.org/wiki/XO_sex-determination_system And in general for HostSex (which can be disaggregated) value spaces |
For HostGender, we should check out and evaluate |
Coming from an anthropological background, glad to see the proposal to split it up! I was also somewhat uncomfortable with fixing the slot for this reason, but continued did so for purely technical reasons. Let me know if you need any further help. Feel free to close the PR if splitting the term is of high priority and the term will be replaced. |
@turbomam I think we should close this and consolidate issues on this theme, including differenting Host vs Organism Sequenced.
I think we'll need more to capture the main axes here. The likely fields will include fields that are
Additional anatomical sites or variants of existing MIxS anatomical groupings will also be needed (e.g. here) |
I've linked this PR in the issue above for documentation, so will close this as suggested by @pbuttigieg |
Additional questions I have: