Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace string serialisation with enum for HostSex categories #849

Closed

Conversation

jfy133
Copy link
Collaborator

@jfy133 jfy133 commented Aug 15, 2024

Additional questions I have:

  • Is there a CHANGELOG I should update?
  • Should I remove the annotation that the expected value is an enumeration?
  • Is there any other areas of the file I should update?
  • Are there any other files I need to update?
  • Do I need to run any other scripts or generate anything else?

@jfy133 jfy133 requested a review from turbomam August 15, 2024 08:12
@turbomam
Copy link
Member

see also

which includes more repairs along the same lines, but also introduces excessive formatting changes

I recommend merging this as soon as possible

Copy link
Member

@turbomam turbomam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent first contribution to mixs.yaml

@jfy133
Copy link
Collaborator Author

jfy133 commented Dec 9, 2024

@turbomam what is the merging protocol here, may I do this when I have an approval? Or do I lead it to a senior project member?

@turbomam
Copy link
Member

turbomam commented Dec 9, 2024

Thanks, removing strings_serializations is a high priority!

@jfy133 thanks for your contribution. I don't think you need any one senior person to approve this, but the decision to merge is usually made live, during a TWG or CIG meeting on Tuesday.

I will advocate for this, but posting in the GSC slack and adding an agenda item to either or both of the meetings notes files will help prioritize your PR

@jfy133
Copy link
Collaborator Author

jfy133 commented Dec 10, 2024

Thanks, removing strings_serializations is a high priority!

@jfy133 thanks for your contribution. I don't think you need any one senior person to approve this, but the decision to merge is usually made live, during a TWG or CIG meeting on Tuesday.

I will advocate for this, but posting in the GSC slack and adding an agenda item to either or both of the meetings notes files will help prioritize your PR

* [GSC Technical WG Meeting Notes 2024](https://docs.google.com/document/d/1MG9JBj9m8Lnev7UBnPGpbQO9ReovswASGNouidjmfx4/edit?tab=t.0#heading=h.2989lvv9mqv5)

* [CIG Running Notes (tomorrow)](https://docs.google.com/document/d/19CWWf1oqMlyH7prteVC5k4eYF_JzJbNqNcvGUyX_U50/edit?tab=t.0#heading=h.mget0ilzdhks)

Great thank you! I can't attend the CIG meeting but I've left an agenda point anyway

@turbomam
Copy link
Member

turbomam commented Dec 10, 2024

Thanks @jfy133. The LinkML implementation here is the ideal outcome.

@pbuttigieg points out that the composition of this enumeration is a case of semantic injection

@mslarae13 points out that the description includes the word "gender"

@turbomam will dig up the NCBI values for this and other sex and gender terms/slots

Do we need to split this out into biological sex and gender terms?

We should include out sources in the LinkML model. @pbuttigieg found this visual for exploring the societal and chromosomal bases of sex and gender. Might not have enough emphasis on developmental outcome of producing gametes of a particular type.

https://docs.google.com/document/d/19CWWf1oqMlyH7prteVC5k4eYF_JzJbNqNcvGUyX_U50/edit?tab=t.0#heading=h.s0d46i1lne1i

https://static.scientificamerican.com/sciam/cache/file/164FE5CE-FBA6-493F-B9EA84B04830354E_source.jpg

@turbomam
Copy link
Member

Ideal outcome: two clearly distinguished terms

  • sex term
  • gender term

@pbuttigieg
Copy link
Collaborator

pbuttigieg commented Dec 10, 2024

https://en.m.wikipedia.org/wiki/XO_sex-determination_system

And in general for HostSex (which can be disaggregated) value spaces
https://en.m.wikipedia.org/w/index.php?title=Sex-determination_system

@pbuttigieg
Copy link
Collaborator

pbuttigieg commented Dec 10, 2024

For HostGender, we should check out and evaluate
https://www.ebi.ac.uk/ols4/ontologies/gsso

@jfy133
Copy link
Collaborator Author

jfy133 commented Dec 10, 2024

Coming from an anthropological background, glad to see the proposal to split it up!

I was also somewhat uncomfortable with fixing the slot for this reason, but continued did so for purely technical reasons.

Let me know if you need any further help. Feel free to close the PR if splitting the term is of high priority and the term will be replaced.

@pbuttigieg
Copy link
Collaborator

pbuttigieg commented Dec 17, 2024

@turbomam I think we should close this and consolidate issues on this theme, including differenting Host vs Organism Sequenced.

Ideal outcome: two clearly distinguished terms

  • sex term
  • gender term

I think we'll need more to capture the main axes here.

The likely fields will include fields that are

  • chromosome based (sex determination),
  • development based (accounting for DSDs, see Conditions for example enumeration),
  • developmental intervention based (including surgical and pharmacological, where relevant and permissable by data protection regulations, relevant for various microbiomes e.g. here, here ,and here)
  • behaviour based (proxied here by gender presentation and/or self identification)

Additional anatomical sites or variants of existing MIxS anatomical groupings will also be needed (e.g. here)

@pbuttigieg
Copy link
Collaborator

xref #838 #517

@jfy133
Copy link
Collaborator Author

jfy133 commented Dec 18, 2024

I've linked this PR in the issue above for documentation, so will close this as suggested by @pbuttigieg

@jfy133 jfy133 closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants