Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure XY: pandas #5

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Figure XY: pandas #5

wants to merge 5 commits into from

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Dec 24, 2024

This PR adds a JN for pandas - tabular data - DataFrame:

  • Figure.plot - scatter plot (color- and size-coding)
  • Figure.histogram (not only maps)

Copy link

gitnotebooks bot commented Dec 24, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/GenericMappingTools/pygmt-paper-figures/pull/5

@seisman
Copy link
Member

seisman commented Jan 4, 2025

@yvonnefroehlich Could you please also include the image in the notebooks, which can make review easier.

@yvonnefroehlich
Copy link
Member Author

@yvonnefroehlich Could you please also include the image in the notebooks, which can make review easier.

I have included the output images within the notebooks for all PRs.

During preparing the AGU24 preworkshop we faced an issue with the review of JNs using gitnotebooks, please see GenericMappingTools/agu24workshop#9 (comment). It looks like that images lead to large diffs and for some JNs these diffs become too large and reviewing the JNs failed, but it worked when not showing the output images (less usage of fig.show or apply “clear all cells” before committing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants