Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compute): multiplication of uints #25

Merged
merged 6 commits into from
Oct 9, 2024
Merged

feat(compute): multiplication of uints #25

merged 6 commits into from
Oct 9, 2024

Conversation

NMCarv
Copy link
Member

@NMCarv NMCarv commented Oct 9, 2024

What was done

  • Implemented multiplication of unsigned integers with the shift-and-add algorithm
    • already faster than FHE!
  • Creation of respective benchmarks
  • Organization of general-purpose circuits on helpers.rs

To be done

  • Multiplication with signed integers!
  • Implement Karatsuba's algorithm

@NMCarv NMCarv requested a review from 10d9e October 9, 2024 14:23
@NMCarv NMCarv self-assigned this Oct 9, 2024
@NMCarv NMCarv added this to the Compute SDK beta milestone Oct 9, 2024
@NMCarv NMCarv linked an issue Oct 9, 2024 that may be closed by this pull request
Create Multiplication gate/operator #1
Closed
10d9e
10d9e approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@10d9e 10d9e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NMCarv NMCarv merged commit 54e1eb1 into main Oct 9, 2024
4 checks passed
@NMCarv NMCarv deleted the feature/multiplication branch October 9, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@10d9e 10d9e 10d9e approved these changes

Assignees

@NMCarv NMCarv

Labels
None yet
Projects
None yet
Milestone
Compute SDK beta
Development

Successfully merging this pull request may close these issues.

Create Multiplication gate/operator
2 participants
@NMCarv @10d9e