Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling does not work any more #84

Open
johann-petrak opened this issue Sep 6, 2018 · 1 comment
Open

Scaling does not work any more #84

johann-petrak opened this issue Sep 6, 2018 · 1 comment

Comments

@johann-petrak
Copy link
Collaborator

This is probably a result of re-factoring so that the engine now decides on which corpus representation to use. But this means the engine has to know how to initialize the corpus representation.

Instead of passing around yet another parameter in all those methods, the idea is to set the scaling method as part of constructing the feature info or set it once the feature info has been created. The feature info gets passed to the corpus representation, so the scaling info could get set from there.
To make this clear we should remove the constructor parameter for the scaling method alltogether.

@johann-petrak
Copy link
Collaborator Author

Fixed in principle, but the whole scaling approach needs to get rivisited #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant