Skip to content

Commit

Permalink
Header Links Not Working on Sign-in Page #243 (#257)
Browse files Browse the repository at this point in the history
<!-- Thank you for sending a pull request ❤️ -->

Closes: #243

This pull request resolves the issue where the header links were not
functioning properly on the sign-in page.


Root Cause: The issue was caused by overlapping elements or missing
event listeners that prevented the header links from being clickable.
The header element was not behaving consistently on the sign-in page
compared to other pages.

## Types of Changes

_Please check the boxes that apply_

- [x] Bugfix (non-breaking change that fixes an issue)
- [] New feature (non-breaking change that adds functionality)
- [] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [] Documentation update (Documentation content changed)
- [ ] Other (please describe):

## Checklist

_Please check the boxes that apply_

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] My changes do not break the current system and pass all existing
test cases
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any dependent changes have been merged and published in downstream
modules



https://github.com/user-attachments/assets/1abdad32-2f26-4031-a6f9-ddba45c86a75


<!-- We're looking forward to merging your contribution!! -->
  • Loading branch information
GarimaSingh0109 authored Oct 11, 2024
2 parents bbeda22 + e5dfac7 commit c970b35
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 10 deletions.
3 changes: 2 additions & 1 deletion ecotips.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@

<body>
<header>
<h1>WasteManagement</h1>

<a href="index.html"><h1>Waste Management</h1></a>
<nav>
<ul>
<li><a href="#eco-tips-container"><i class="fa-brands fa-pagelines"></i> Tips</a></li>
Expand Down
3 changes: 2 additions & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
</div>

<header>
<h1>Waste Management</h1>
<a href="index.html"><h1>Waste Management</h1></a>

<nav>
<ul>
<li><a href="#upload">Upload</a></li>
Expand Down
17 changes: 9 additions & 8 deletions register.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,20 @@
<body class="register-body">

<header>
<h1>Waste Management</h1>
<a href="index.html"><h1>Waste Management</h1></a>

<nav>
<ul>
<li><a href="#upload">Upload</a></li>
<li><a href="#features">Features</a></li>
<li><a href="../WasteManagment/CARBON FOOTPRINT CALC/welcome.html">Carbon footprint</a></li>
<li><a href="#feedback">Feedback</a></li>
<li><a href="index.html">Upload</a></li>
<li><a href="index.html">Features</a></li>
<li><a href="index.html">Carbon footprint</a></li>
<li><a href="index.html">Feedback</a></li>

<li><a href="#about">About Me</a></li>
<li><a href="index.html">About Me</a></li>

<li><a href="register.html">Sign up</a></li>
<li><a href="index.html">Sign up</a></li>

<li><a href="#footer">Contact</a></li>
<li><a href="index.html">Contact</a></li>
<li class="theme-switch" id="theme-switch"></li>
</ul>
</nav>
Expand Down
12 changes: 12 additions & 0 deletions styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,18 @@ body {
transition: background-color 0.3s, color 0.3s;
}

a {
text-decoration: none;
}

h1 {
font-size: 2.5rem;
font-weight: bold;
color: #333;
margin: 0;
padding: 0;
}

.dark-mode {
background-color: var(--dark-bg);
color: var(--light-bg);
Expand Down

0 comments on commit c970b35

Please sign in to comment.