fix: add net income to equity account set #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to nest Net Income under Equity in the balance sheet without duplicating account in the Chart of Accounts acocunt set.
2 tasks
nicolasburtey
approved these changes
Jul 30, 2024
thevaibhav-dixit
pushed a commit
that referenced
this pull request
Jul 30, 2024
* refactor: rename retained_earnings to net_income, nest in P&L * refactor: add separate 'equity_for_chart_of_accounts' set to fix DAG This allows us to nest Net Income under Equity in the balance sheet without duplicating account in the Chart of Accounts acocunt set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with adding Revenue and Expense accounts twice to Chart of Accounts via "Net Income in Equity". It creates a separate duplicate account set for equity for the chart of accounts.
This isn't ideal since we'd need to add all related children accounts/acocunt-sets to both
Equityaccount sets.DAG problem described in GaloyMoney/cala#176