Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 boom(quantity): rename UncheckedQuantity to BareQuantity #386

Merged
merged 1 commit into from
Feb 5, 2025
Merged

💥 boom(quantity): rename UncheckedQuantity to BareQuantity #386

merged 1 commit into from
Feb 5, 2025

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Jan 30, 2025 •
edited
Loading

Fixes #380

@nstarman nstarman added this to the v1.1.0 milestone Jan 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.78%. Comparing base (841a128) to head (e90a3b7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/unxt/_interop/unxt_interop_mpl/__init__.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   97.76%   97.78%   +0.01%     
==========================================
  Files          46       46              
  Lines        1610     1622      +12     
  Branches      320      321       +1     
==========================================
+ Hits         1574     1586      +12     
  Misses         29       29              
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman
Copy link
Contributor Author

Ping @adrn @jeffjennings

@nstarman nstarman force-pushed the quantity/barequantity branch from 9548eea to 7bfdd96 Compare January 30, 2025 04:27
@nstarman
Copy link
Contributor Author

Oops. Needs a deprecation! I'll whip something up.

@nstarman
💥 boom(quantity): rename UncheckedQuantity to BareQuantity
e90a3b7 
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
@nstarman nstarman force-pushed the quantity/barequantity branch from 7bfdd96 to e90a3b7 Compare January 30, 2025 16:38
@nstarman nstarman requested a review from adrn January 30, 2025 16:39
@nstarman
Copy link
Contributor Author

Done.

@nstarman nstarman marked this pull request as ready for review January 30, 2025 22:11
@nstarman nstarman merged commit bf62bbe into GalacticDynamics:main Feb 5, 2025
21 of 22 checks passed
@nstarman nstarman deleted the quantity/barequantity branch February 5, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrn adrn Awaiting requested review from adrn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Change name of UncheckedQuantity
1 participant
@nstarman