-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat(quantity): enable non-Array quax.ArrayValue as Quantity's value #358
✨ feat(quantity): enable non-Array quax.ArrayValue as Quantity's value #358
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
==========================================
+ Coverage 97.72% 97.75% +0.03%
==========================================
Files 45 46 +1
Lines 1579 1606 +27
Branches 316 320 +4
==========================================
+ Hits 1543 1570 +27
Misses 29 29
Partials 7 7 ☔ View full report in Codecov by Sentry. |
67a9110
to
72e9b00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea! On the name: maybe convert_to_value
or convert_to_unxt_value
instead of noun _converter
?
72e9b00
to
dc63a81
Compare
@adrn Agreed. I pushed another gross name. It would be good to think of a good one 😆. |
dc63a81
to
0fab4b0
Compare
How about just |
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
0fab4b0
to
974e657
Compare
Changed! Let's get it in. |
Part of the push for unxt v1.1, to enable more value types, e.g. the low rank array in the test.