Fixed crashes upon harvesting of Praecantatio Infused Seeds #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed Seeds Signed-off-by: ClassixX <30446897+ClassixX@users.noreply.github.com>
chochem
reviewed
Dec 9, 2024
src/main/java/thaumic/tinkerer/common/core/helper/AspectCropLootManager.java
Outdated
Show resolved
Hide resolved
Deleted previously commented out line
|
Why are there 7 drops coded? There should only be 6 shards. |
Balanced shards dude |
I am an idiot |
serenibyss
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that causes crashes upon harvesting of Praecantatio Infused Seeds
Praecantatio Infused Seeds had their loot set to be any item that contains "materialAspectShard" in their oreDic. This causes the game to crash upon generating loot of this crop for unknown reasons.
This PR removes this bug by individually adding the respective items.
The crop will now drop any of the base Thaumcraft shards.
Should Forbidden Magic Shards (Envy, Wrath, etc.) be included in this? The original code would not have found those either.
Signed-off-by: ClassixX 30446897+ClassixX@users.noreply.github.com