forked from MuXiu1997/Share-Where-I-am
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollback to java + Navigator compact for JM #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenibyss
reviewed
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the massive effort. I have some comments on the port and some suggested improvements
src/main/java/com/muxiu1997/sharewhereiam/client/key/KeyShare.java
Outdated
Show resolved
Hide resolved
src/main/java/com/muxiu1997/sharewhereiam/command/CommandWaypointSave.java
Outdated
Show resolved
Hide resolved
src/main/java/com/muxiu1997/sharewhereiam/command/CommandWaypointShareLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/muxiu1997/sharewhereiam/command/base/CommandWaypointBase.java
Outdated
Show resolved
Hide resolved
src/main/java/com/muxiu1997/sharewhereiam/core/ShareWhereIAmCore.java
Outdated
Show resolved
Hide resolved
src/main/java/com/muxiu1997/sharewhereiam/loader/IntegrationLoader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/muxiu1997/sharewhereiam/loader/KeyLoader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/muxiu1997/sharewhereiam/loader/NetworkLoader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/muxiu1997/sharewhereiam/util/VPWaypointUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/muxiu1997/sharewhereiam/util/VPWaypointUtil.java
Outdated
Show resolved
Hide resolved
serenibyss
approved these changes
Dec 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this PR, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GTNewHorizons/GT-New-Horizons-Modpack#18325, fix GTNewHorizons/GT-New-Horizons-Modpack#18324
Moved the mod to Java. Same functionality.
If you want, I can try to add support for other mini-maps through Navigator.
Tested in release 2.7.0, but please test it for any bugs.
Any feedback is welcome.