Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback to java + Navigator compact for JM #5

Merged
merged 6 commits into from
Dec 29, 2024

Conversation

0hwx
Copy link

@0hwx 0hwx commented Dec 12, 2024

Fix GTNewHorizons/GT-New-Horizons-Modpack#18325, fix GTNewHorizons/GT-New-Horizons-Modpack#18324

Moved the mod to Java. Same functionality.

If you want, I can try to add support for other mini-maps through Navigator.

Tested in release 2.7.0, but please test it for any bugs.

Any feedback is welcome.

@Dream-Master Dream-Master requested a review from a team December 12, 2024 20:47
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the massive effort. I have some comments on the port and some suggested improvements

Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR, thanks!

@serenibyss serenibyss merged commit 52c5b7d into GTNewHorizons:master Dec 29, 2024
1 check passed
@0hwx 0hwx deleted the Rollback-to-java branch December 29, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants