Fix the healing axe not healing entities when attacking them #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenibyss
reviewed
Mar 20, 2025
src/main/java/com/mitchej123/hodgepodge/mixins/late/extrautilities/MixinItemHealingAxe.java
Outdated
Show resolved
Hide resolved
serenibyss
reviewed
Mar 22, 2025
Comment on lines
+35
to
+39
| if (player.getHealth() - (k - 0.5F) > 0F) { | ||
| player.setHealth(player.getHealth() - (k - 0.5F)); | ||
| } else { | ||
| player.attackEntityFrom(DamageSource.causePlayerDamage(player), (k - 0.5F)); | ||
| } |
There was a problem hiding this comment.
Right now this drains player health even if the clicked entity is not healed, I think it should only drain player health based on health given to the entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the healing axe doesn't actually heal mobs like its description says it should because of a bug/typo, the original code has
target.getHealth() < target.getHealth()as a condition to healThe description says "it will take some health from you and use it to heal the target, with a slight bonus", considering what pack this is i interpreted that as taking a quarter heart less than it heals
I'm a pretty new player and I don't have access to the dev discord channels so I'm not sure how exactly this will affect balance so I'll leave discussing that to the actual developers.