Optimize NBT comparisons by caching the hash code for NBTagCompound and NBTTagList #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cached hash code is calculated lazily, so the only way this could potentially perform worse is when TagCompounds/TagLists that are equal (but not copied) are compared exactly once, as in that case it now also calculates the hash code instead of just directly comparing.
But this should realistically happen very rarely, if ever, and for 2+ comparisons it should be faster (or at least not slower), because it'll use the cached hash code to early return.
I wasn't really able to profile the performance gain, so if anyone wants to, go for it.
But i imagine that this impacts stuff like ItemStack comparisons the most.