fix wrong block placement distance check

[Pilzinsel64]

Fix block placement distance by players being wrong.

Typical symptom are blocks on the ceiling that disappear shortly after you you placed them. You can't place a block at the ceiling but can remove the block above it. Introduces in the past when Notch splitted of the server. If I'm not wrong, it's fixed in modern Minecraft versions.

Before:
https://github.com/user-attachments/assets/d2c328ec-3442-4a6e-888b-c6792e4b6e09

After:
https://github.com/user-attachments/assets/58d47d67-ea92-4974-904d-a0cfcb93400c

[Ethryan]

LGTM, but I’m not really used to mixin code so I could have missed something.

[Caedis]

I did find this

double d1 = player.prevPosY + (player.posY - player.prevPosY) * (double)f + (double)(worldIn.isRemote ? player.getEyeHeight() - player.getDefaultEyeHeight() : player.getEyeHeight()); // isRemote check to revert changes to ray trace position due to adding the eye height clientside and player yOffset differences

Might want to look at that instead of using a hardcoded value

[Pilzinsel64]

Might want to look at that instead of using a hardcoded value

Would be an idea to use the eye height, yes. But would need to do in the other method too. Can't today, maybe tomorrow.
@Caedis where did you find this snippet?

[Pilzinsel64]

getEyeHeight() and getDefaultEyeHeight() returns 0.12 and not 0.15 where 0.15 I grabbed from NetHandlerPlayServer.processPlayerDigging(). Not sure what's correct or where exactly is the client-side check.
@Caedis Can you point me a bit to the right direction please? I'm a bit slow on the uptake. 🙈

[Caedis]

getDefaultEyeHeight() should be returning a static 1.5

or not....

EntityPlayerMP overrides it

@Override
    public float getDefaultEyeHeight()
    {
        return 1.62F;
    }

[Caedis]

@Pilzinsel64 can you link the mc bug report since you say it was fixed in modern?

[Pilzinsel64]

can you link the mc bug report since you say it was fixed in modern?

@Caedis Nah, sorry, didn't found it. I just remember that behavior didn't appear again in later versions. Not even sure when exactly it was fixed.

EntityPlayerMP overrides it

@Caedis Maybe that is the problem? However, not sure what I should do now. Should I just use getEyeHeight()?

[Dream-Master]

not merge yet need some more work Pilzinsel told me

[Pilzinsel64]

Quick update, can be merged from my side now. Using entity.getEyeHeight() instead of the constant value `1.5D.

There could be added a second method in the same mixin here with a future PR to also optimize the processPlayerDigging() method and also use entity.getEyeHeight() instead of the constant value there. However, this would lead to even more work in the renderer probably and isn't just a small fix then.

@Caedis hope that's also fine for you.

[Caedis]

Tested on both SP and MP?

[Pilzinsel64]

Tested on both SP and MP?

@Caedis Only SP yet. Not sure if @Dream-Master put this on Zeta yet. Can't get the obfuscated jar of Hodgepodge to work on client for some reason since the last rebase on master.

[Dream-Master]

works on zeta
https://cdn.discordapp.com/attachments/521008249844269061/1322308881640063037/2024-12-27_22-02-20.mp4?ex=6770679c&is=676f161c&hm=a32b52b49360c0e61c149898add5f770c5436914daa1cf4485e91a2af2a6fa2d&