Fix off by one int clamp in Witchery's glyph rendering #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Warning: 2 uncommitted changes |
Caedis
approved these changes
Dec 9, 2024
Dream-Master
pushed a commit
that referenced
this pull request
Dec 10, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit ad9680d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a possible AIOOB caused by an int clamp being wrong in Witchery's rendering. This bug is hard to reproduce and not sure exactly where the problem comes from, but there seems to be some kind of edge case, in some combination of mods and things happening, where a glyph's metadata can be above the expected max of 11. Witchery has a clamp that prevents that would prevent that from causing an AIOOB, however the clamp is incorrect and off by one, so this makes it so the clamp at least works and prevents a crash.
See GTNewHorizons/Angelica#778 for the original crash