feat: patch several dupes in eu2 #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two dupes in EU2, one of which involving a Bag of Holding and an Item Filter, the other involving any backpack-esque item and a Filing Cabinet, both due to buggy hotkey logic.
The filter dupe will let you hotkey a Bag of Holding onto the filter in your hotbar while you have it open, and then put ghost items into the "filter" like normal, instead putting them into the Bag of Holding.
This is mitigated by verifying that the slot you are hotkeying onto isn't also the currently active slot.
The Filing Cabinet doesn't cap the item stack size when you hotkey an itemstack to your inventory, allowing you to store two backpacks, pull out the stacked items, put an item in them, unstack them, and pull the item out of both of them.
This is mitigated by modifying the stack size temporarily, then restoring it after the item has been moved.