Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove annoying GL error message from Optifine/Shadersmod #279

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

Caedis
Copy link
Member

@Caedis Caedis commented Nov 14, 2023

Confirmed working when running the modified Complementary Shaders that Sampsa uses.

@Caedis Caedis requested a review from a team November 14, 2023 17:52
@Caedis Caedis enabled auto-merge (squash) November 14, 2023 17:52
@Caedis
Copy link
Member Author

Caedis commented Nov 14, 2023

maxStack is still 1 because the value from glGetError is put onto the stack and then return is called.

@bombcar
Copy link
Member

bombcar commented Nov 15, 2023

Spotless Is gonna have a heart attack on that wildcard import

@Caedis Caedis merged commit 08e989c into master Nov 15, 2023
1 check passed
@Caedis Caedis deleted the feat/glErrorMute branch November 15, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants