Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Wireless Detectors with toggle-able sided redstone manipulation #3617

Conversation

Sanduhr32
Copy link
Contributor

The follow up as requested in PR #3595 by @OneEyeMaker
Still related to GTNewHorizons/GT-New-Horizons-Modpack#18177

I've tested the GUI changes so they look like previous commits, but with this extra row of button & text.
Also includes localization following the example @serenibyss provided me on discord.

I'ld like your opinion whether i should create a custom background for this new button,
as i'ld like to use the emitter or transmission component for the wireless only mode
and one that's half mentioned gt metaitem & half redstone dust for the "hybrid" mode.

@Dream-Master Dream-Master requested a review from a team December 9, 2024 14:47
@Dream-Master Dream-Master added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Dec 9, 2024
@serenibyss
Copy link
Member

@OneEyeMaker are you able to take a look at this when you get a chance?

@Dream-Master Dream-Master requested a review from a team December 19, 2024 19:31
@Sanduhr32
Copy link
Contributor Author

Due to personal reasons, I am unavailable until next year.
Frohe Weihnachten & Guten Rutsch!

@Dream-Master
Copy link
Member

Due to personal reasons, I am unavailable until next year. Frohe Weihnachten & Guten Rutsch!

Frohe Weihnachten & Guten Rutsch! Ebenso :)

@serenibyss serenibyss added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 29, 2024
@Dream-Master Dream-Master enabled auto-merge (squash) January 5, 2025 11:37
@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 5, 2025
@Dream-Master Dream-Master merged commit 6a2cff6 into GTNewHorizons:master Jan 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants