-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Wireless Detectors with toggle-able sided redstone manipulation #3617
Merged
Dream-Master
merged 21 commits into
GTNewHorizons:master
from
Sanduhr32:enhancement/toggle-detector-redstone-behavior
Jan 5, 2025
Merged
Enhance Wireless Detectors with toggle-able sided redstone manipulation #3617
Dream-Master
merged 21 commits into
GTNewHorizons:master
from
Sanduhr32:enhancement/toggle-detector-redstone-behavior
Jan 5, 2025
+213
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dream-Master
added
the
enhancement
Improve an existing mechanic. Please explain the change with a before/after comparison.
label
Dec 9, 2024
@OneEyeMaker are you able to take a look at this when you get a chance? |
OneEyeMaker
requested changes
Dec 19, 2024
src/main/java/gregtech/common/covers/redstone/CoverWirelessDoesWorkDetector.java
Outdated
Show resolved
Hide resolved
Due to personal reasons, I am unavailable until next year. |
Frohe Weihnachten & Guten Rutsch! Ebenso :) |
OneEyeMaker
approved these changes
Jan 5, 2025
Dream-Master
removed
the
🚧 Testing on Zeta
Do not merge yet, testing this PR on Zeta
label
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improve an existing mechanic. Please explain the change with a before/after comparison.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The follow up as requested in PR #3595 by @OneEyeMaker
Still related to GTNewHorizons/GT-New-Horizons-Modpack#18177
I've tested the GUI changes so they look like previous commits, but with this extra row of button & text.
Also includes localization following the example @serenibyss provided me on discord.
I'ld like your opinion whether i should create a custom background for this new button,
as i'ld like to use the emitter or transmission component for the wireless only mode
and one that's half mentioned gt metaitem & half redstone dust for the "hybrid" mode.