Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinker repair in the tool forge/station repair calculation is inconsistent in some cases #18556

Open
2 of 3 tasks
Worive opened this issue Dec 28, 2024 · 0 comments
Open
2 of 3 tasks
Labels
Bug: Minor Mod: Tinkers' Construct Status: Ready for Developer Issue ready for a developer to pick up and implement

Comments

@Worive
Copy link
Contributor

Worive commented Dec 28, 2024

Your GTNH Discord Username

Worive

Your Pack Version

2.7.0

Your Server

Private

Java Version

Java 21

Type of Server

Vanilla Forge

Your Expectation

Repairing using ingots should always be properly counted, and if you put too many materials to repair, refuse to repair.

The Reality

Various situations:

  • Sometimes putting too many materials will actually decrease the final durability after repair
  • Sometimes an ingot will be counted as only 2 of durability instead of their full value

Example of case 2:

  1. 1753/2204 durability tool
  2. +1 ingot -> 2094/2204
  3. +2 ingot -> 2096/2204

Your Proposal

I'll try to see if I can fix it myself 👍 even more, apparently it's been around since the beginning

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@Worive Worive added Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed labels Dec 28, 2024
@Worive Worive changed the title Tinker repair in the tool forge/station Tinker repair in the tool forge/station repair calculation is inconsistent in some cases Dec 28, 2024
@Ruling-0 Ruling-0 added Mod: Tinkers' Construct Status: Ready for Developer Issue ready for a developer to pick up and implement and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Mod: Tinkers' Construct Status: Ready for Developer Issue ready for a developer to pick up and implement
Projects
None yet
Development

No branches or pull requests

2 participants