Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pattern invalid if recipe changed or make a list of changed recipes for every update #18044

Open
4 tasks done
dimazha opened this issue Nov 20, 2024 · 3 comments
Open
4 tasks done

Comments

@dimazha
Copy link

dimazha commented Nov 20, 2024

Your GTNH Discord Username

Dart_Voider

Your Pack Version

2.7.0-nightly-700

Your Proposal

Make pattern invalid if recipe changed or make a list of changed recipes for every update. It can be just a document with names of items, but invalid patterns would be better

Your Goal

Changed recipes are not displayed in any way. Player finds out that the recipe has changed only when autocraft gets stuck. In case of big crafts ME can pull millions of wrong ingredients. Also ME can't continue craft if pattern has changed so items with changed recipes must be ordered manually. And yeah, serial crafts like Energy Cores must be ordered in turn (MV-HV-EV etc.) because ongoing craft can't accept items that are not highlighted in green.

Your Vision

Broken patterns won't work, so players will get a possibility to recode them without breaking big craft because of changing 1-2 recipes in it. It is absolutely impossible to check manually thousands of patterns to find changed recipes. So now the only way to know about changing is a stucked craft

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying I like this change please reconsider adding it will prompt us to investigate and reopen it once we confirm your report.
  • I understand this change request may not attract enough attention and thus not be implemented.
  • I understand this change request may be rejected due to other community members think it's inappropriate.
  • I believe this feature would make the pack better.
@dimazha dimazha added Status: Triage Issue awaiting triage. Remove once this issue is processed Suggestion labels Nov 20, 2024
@Alexdoru
Copy link
Member

the regular crafting table patterns are already invalidated automatically, however for the processing patterns we cannot do that because it is in the design of AE2 to let the players make any pattern they want and it doesn't have to match any actual recipe

However I agree that it would be nice to have a changelog with the list of all changed recipes so that we can update our patterns before having a disaster

@Alexdoru Alexdoru removed the Status: Triage Issue awaiting triage. Remove once this issue is processed label Nov 20, 2024
@AbdielKavash
Copy link
Member

AbdielKavash commented Nov 20, 2024

As Alex says, "invalid processing pattern" fundamentally doesn't make sense in the way AE works. I can make a pattern that says 1 dirt + 1 cobblestone -> 1 stargate block, and AE can faithfully execute it (and there are many good reasons for it being able to work this way).

But a list of changed recipes would be nice; and could likely be auto-generated, at least for a reasonably large subset of the pack (e.g., GT5/RA2 recipes).

@chochem
Copy link
Member

chochem commented Nov 23, 2024

the list is here: https://gtnh.miraheze.org/wiki/Upcoming_Features#Breaking_Changes
it just isnt super well maintained, so don't expect it to be complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants