Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinkers Tools cannot be renamed after initial craft #16035

Closed
2 of 3 tasks
imTheSupremeOne opened this issue Apr 21, 2024 · 3 comments
Closed
2 of 3 tasks

Tinkers Tools cannot be renamed after initial craft #16035

imTheSupremeOne opened this issue Apr 21, 2024 · 3 comments

Comments

@imTheSupremeOne
Copy link

imTheSupremeOne commented Apr 21, 2024

Your GTNH Discord Username

imthesupremeone

Your Pack Version

2.5.1

Your Server

Private

Java Version

Java 21

Type of Server

Don't know

Your Expectation

Tool should be renamed after going through Tool Forge :
image

The Reality

Nothing happens.
image

As you can see the font is already italic and it's because I've tried battling it before and failed but was too lazy to report it here. Even if tool at 100% durability; I also tried mb to enforce it by doing repair + rename at the same time but it stays with the name it was crafted.

If tool wasn't given any custom name at first assembly it can not be renamed either :
image

Renaming tool with anvil isn't perfect too. It changes it's font to italic and technically the Tinker Name still stays on the tool :
image

Your Proposal

Fix Tool Forge Renaming.

Prob look at anvil renaming too as it's clearly isn't fully supported to work at Tinker's tools.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@imTheSupremeOne imTheSupremeOne added Status: Triage Issue awaiting triage. Remove once this issue is processed Bug: Minor labels Apr 21, 2024
@RealSilverMoon
Copy link
Contributor

public static boolean canRename(NBTTagCompound tags, ItemStack tool) {
This means a tool can only be renamed once. Seems that this logic was decided at the very beginning. I would say it's time to change that—give renaming permissions to players doesn't hurt anything.

@GirixK GirixK added Type: Enhancement Status: Ready for Developer Issue ready for a developer to pick up and implement and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Nov 11, 2024
@chochem
Copy link
Member

chochem commented Nov 15, 2024

you should be able to rename it again with a nametag, that is the intention anyway.

@chochem chochem added Type: Not a Bug Is not actually a bug. and removed Bug: Minor Status: Ready for Developer Issue ready for a developer to pick up and implement labels Nov 15, 2024
@chochem
Copy link
Member

chochem commented Nov 15, 2024

I tested it to be sure, and yea works just fine

image
image
image

@chochem chochem closed this as completed Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants