Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT Tools can no longer have the Resolute Ivy due to audio bugs #65

Closed
wants to merge 1 commit into from

Conversation

Caedis
Copy link
Member

@Caedis Caedis commented Dec 8, 2024

Fixes an issue where GT tools play their breaking sound when put in the crafting grid and any time the crafting grid changes.

This is because the GT metatool's getContainerItem calls doDamage which plays the tool sounds

@Caedis Caedis requested a review from a team December 9, 2024 18:35
@Caedis Caedis enabled auto-merge (squash) December 9, 2024 18:35
@combusterf
Copy link
Collaborator

This is because the GT metatool's getContainerItem calls doDamage which plays the tool sounds

That sounds like entirely GT's fault and this would then be the wrong place to fix it?

@boubou19
Copy link
Member

boubou19 commented Dec 9, 2024

at this point i'd just yeet the sound when using the tools, no one will really notice, and it causes more issues than anything

@Caedis
Copy link
Member Author

Caedis commented Dec 10, 2024

Gonna switch back to trying to fix it in GT

@Caedis Caedis closed this Dec 10, 2024
auto-merge was automatically disabled December 10, 2024 14:01

Pull request was closed

@Dream-Master Dream-Master deleted the fixGTToolSounds branch December 10, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants