backported item filter for Rannuncarpus #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 1d6e233)
|
Sure you can make more prs if you like . We backport much stuff from new ender io version as well @shadoxxhd |
|
@Dream-Master what they linked is not newer botania. just their personal random buff fork. |
|
Ah it sounds to me that it is stuff from newer botania version |
|
rannuncarpus filter is. the rest is not. |
|
I assumed you meant I should just make a PR to "see what sticks" from my preference changes; I can close the other PR if that is not how you usually review random suggestions/ideas/preferences. |
Let the pr open we can discuss it and see what we pull in. |
serenibyss
approved these changes
Dec 27, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
might be useful to have in the main Botania version for 1.7.10
(you could also have a look at https://github.com/shadoxxhd/Botania/releases/tag/1.11.5-c - some of these changes might or might not also be of interest)