Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fake crafting card for AE #622

Merged
merged 13 commits into from
Dec 23, 2024

Conversation

MCTBL
Copy link
Member

@MCTBL MCTBL commented Dec 14, 2024

output.mp4

this upgrade can finish crafting job without receiving output

item fake crafting normal
image image image

@chochem chochem added the new feature Add something new. Please explain in detail how it works. label Dec 16, 2024
@serenibyss
Copy link
Member

Why does this have a button to toggle the mode? Shouldn't an interface having the card enable this functionality, then not having the card is like normal?

@miaowwwwww
Copy link
Member

Why does this have a button to toggle the mode? Shouldn't an interface having the card enable this functionality, then not having the card is like normal?

so that players have the option to not remove the card and to just toggle it off.

@MCTBL
Copy link
Member Author

MCTBL commented Dec 18, 2024

Why does this have a button to toggle the mode? Shouldn't an interface having the card enable this functionality, then not having the card is like normal?

I'm not sure if there has any player would use this in some time, so i add it.

@serenibyss
Copy link
Member

I don't see why we should add more to the UI when this card is already a toggle on its own

@Dream-Master Dream-Master requested a review from a team December 21, 2024 12:38
@MCTBL MCTBL requested a review from lordIcocain December 23, 2024 16:11
@Dream-Master Dream-Master enabled auto-merge (squash) December 23, 2024 19:27
@Dream-Master Dream-Master merged commit 7c369c9 into GTNewHorizons:master Dec 23, 2024
1 check passed
michaeldoylecs pushed a commit to michaeldoylecs/Applied-Energistics-2-Unofficial that referenced this pull request Jan 4, 2025
Co-authored-by: Martin Robertz <dream-master@gmx.net>
Co-authored-by: Maya <10861407+serenibyss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Add something new. Please explain in detail how it works.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants