Add explicit support for BuildCraft, CoFH wrenches

[firenoo]

Uses AE2's integration system to add support for Thermal Expansion wrenches

• Refactor ToolQuartzWrench and ToolNetworkTool, move BC optional interface IToolWrench to IAEWrench
• Adds IToolHammer to IAEWrench

Fixes #395

[github-actions]

Warning: 2 uncommitted changes
#397

[miozune]

I don't understand the issue, ThermalExpansion Crescent Hammer doesn't let me pick up the cable without BC, even before my patch #385

[firenoo]

Since your code most recently touched wrench code, I assumed it had to do with the issue. Apologies if I offended you.
But even so, it's a bug with the way it is implemented, and id like to fix that. If BC is not loaded, then it will definitely not work since AE only knows about the crescent hammer's wrenching ability from IToolWrench, if cofh's source is trustable.

[miozune]

We can use IToolHammer from CoFH Core

And no, I don't feel offended. Everyone makes mistakes 😉

[firenoo]

I wanted to avoid having to make multiple optional deps.
but I see now that the wrenchers map will fill up with random item entries so that'll need a rewrite anyways.
Sadly we can't put the onus on cofh to provide compat :( so maybe using IToolHammer is right (if the hammer actually extends it)

[Alastors]

Optional dependency > hard dependency when applicable

Just a little more work, but it's usually worth in my opinion, def energy draining tho

[firenoo]

we are already talking about optional deps here, just how to implement it 😉

[miozune]

It's not hard, cofhloaded && item instanceof IToolHammer, just like I did with IToolWrench
You can check code for crescent hammer here

[firenoo]

Don't worry, I am no stranger to optional dep implementation. I meant that I don't necessarily agree with the previous implementation (both yours and mine) now that I've looked closer at how AE2 does integration. To maintain consistency with the rest of the mod - at least until we refactor that part (if we ever want to) - its probabaly better to use these annotations: https://github.com/GTNewHorizons/Applied-Energistics-2-Unofficial/blob/master/src/main/java/appeng/transformer/annotations/Integration.java and create a new IntegrationType for CoFHCore/ThermalExpansion (or rather, re-add it since it was removed at some point)

[miozune]

Isn't @Integration basically the same as @Optional? But IIntegrationModule implementation sounds good

[glowredman]

The problem with checking the modid to decide whether to enable/disable the compat is, that the APIs can (and often are) shaded in other mods. "CoolWrenchMod" might shade both the BC API and the CoFH API and expect the Interaction with AE to work, even though neither BuildCraft or CoFHCore are present. IIRC FML provides a method to check if an API is loaded, so maybe it is possible to use that.

[glowredman]

Just checked, it is ModAPIManager.hasAPI(String)

[miozune]

AE2 IIntegrationModule already checks that, see IntegrationNode

[firenoo]

@miozune implemented. lmk if it looks better

[miozune]

PartP2PTunnelStatic still references raw IToolWrench