Reduce interface terminal TPS impact + break some backends + new gui

src/main/java/appeng/client/gui/IInterfaceTerminalPostUpdate.java

@@ -0,0 +1,16 @@
+package appeng.client.gui;
+
+import java.util.List;
+
+import appeng.core.sync.packets.PacketIfaceTermUpdate.PacketEntry;
+
+public interface IInterfaceTerminalPostUpdate {
+
+    /**
+     * Interface to handle updates inside interface terminal
+     *
+     * @param updates     List of updates
+     * @param statusFlags status bitflags
+     */
+    void postUpdate(List<PacketEntry> updates, int statusFlags);
+}

src/main/java/appeng/client/gui/implementations/GuiInterfaceTerminal.java

@@ -48,6 +48,7 @@
 import appeng.api.util.WorldCoord;
 import appeng.client.gui.AEBaseGui;
 import appeng.client.gui.IGuiTooltipHandler;
+import appeng.client.gui.IInterfaceTerminalPostUpdate;
 import appeng.client.gui.widgets.GuiImgButton;
 import appeng.client.gui.widgets.GuiScrollbar;
 import appeng.client.gui.widgets.IDropToFillTextField;
@@ -89,7 +90,8 @@
  *
  * @author firenoo
  */
-public class GuiInterfaceTerminal extends AEBaseGui implements IDropToFillTextField, IGuiTooltipHandler {
+public class GuiInterfaceTerminal extends AEBaseGui
+        implements IDropToFillTextField, IGuiTooltipHandler, IInterfaceTerminalPostUpdate {
 
     public static final int HEADER_HEIGHT = 52;
     public static final int INV_HEIGHT = 98;
@@ -752,6 +754,7 @@ private boolean handleTab() {
         return false;
     }
 
+    @Override
     public void postUpdate(List<PacketEntry> updates, int statusFlags) {
         if ((statusFlags & PacketIfaceTermUpdate.CLEAR_ALL_BIT) == PacketIfaceTermUpdate.CLEAR_ALL_BIT) {
             /* Should clear all client entries. */

src/main/java/appeng/container/implementations/ContainerInterfaceTerminal.java

@@ -42,6 +42,7 @@
 import appeng.core.sync.packets.PacketIfaceTermUpdate;
 import appeng.helpers.InventoryAction;
 import appeng.items.misc.ItemEncodedPattern;
+import appeng.parts.AEBasePart;
 import appeng.parts.reporting.PartInterfaceTerminal;
 import appeng.util.InventoryAdaptor;
 import appeng.util.Platform;
@@ -305,7 +306,8 @@ private PacketIfaceTermUpdate updateList() {
                     /* Add a new entry */
                     if (update == null) update = new PacketIfaceTermUpdate();
                     InvTracker entry = new InvTracker(nextId++, machine, node.isActive());
-                    update.addNewEntry(entry.id, entry.name, entry.online).setLoc(entry.x, entry.y, entry.z, entry.dim)
+                    update.addNewEntry(entry.id, entry.name, entry.online)
+                            .setLoc(entry.x, entry.y, entry.z, entry.dim, entry.side.ordinal())
                             .setItems(entry.rows, entry.rowSize, entry.invNbt)
                             .setReps(machine.getSelfRep(), machine.getDisplayRep());
                     tracked.put(machine, entry);
@@ -355,6 +357,7 @@ private static class InvTracker {
         private final int y;
         private final int z;
         private final int dim;
+        private final ForgeDirection side;
         private boolean online;
         private NBTTagList invNbt;
 
@@ -370,6 +373,7 @@ private static class InvTracker {
             this.y = location.y;
             this.z = location.z;
             this.dim = location.getDimension();
+            this.side = machine instanceof AEBasePart hasSide ? hasSide.getSide() : ForgeDirection.UNKNOWN;
             this.online = online;
             this.invNbt = new NBTTagList();
             updateNBT();
@@ -409,16 +413,4 @@ private void updateNBT() {
             }
         }
     }
-    //
-    // private static class PatternInvSlot extends WrapperInvSlot {
-    //
-    // public PatternInvSlot(final IInventory inv) {
-    // super(inv);
-    // }
-    //
-    // @Override
-    // public boolean isItemValid(final ItemStack itemstack) {
-    // return itemstack != null && itemstack.getItem() instanceof ItemEncodedPattern;
-    // }
-    // }
 }

src/main/java/appeng/core/sync/packets/PacketIfaceTermUpdate.java

@@ -13,7 +13,7 @@
 import net.minecraft.nbt.NBTTagList;
 import net.minecraftforge.common.util.Constants.NBT;
 
-import appeng.client.gui.implementations.GuiInterfaceTerminal;
+import appeng.client.gui.IInterfaceTerminalPostUpdate;
 import appeng.core.AELog;
 import appeng.core.sync.AppEngPacket;
 import appeng.core.sync.network.INetworkInfo;
@@ -103,7 +103,7 @@ public void setDisconnect() {
 
     /**
      * Adds a new entry. Fill out the rest of the command using the {@link PacketAdd#setItems(int, int, NBTTagList)} and
-     * {@link PacketAdd#setLoc(int, int, int, int)}.
+     * {@link PacketAdd#setLoc(int, int, int, int, int)}.
      *
      * @return the packet, which needs to have information filled out.
      */
@@ -143,8 +143,8 @@ public PacketOverwrite addOverwriteEntry(long id) {
     public void clientPacketData(final INetworkInfo network, final AppEngPacket packet, final EntityPlayer player) {
         final GuiScreen gs = Minecraft.getMinecraft().currentScreen;
 
-        if (gs instanceof GuiInterfaceTerminal) {
-            ((GuiInterfaceTerminal) gs).postUpdate(this.commands, this.statusFlags);
+        if (gs instanceof IInterfaceTerminalPostUpdate hasPostUpdate) {
+            hasPostUpdate.postUpdate(this.commands, this.statusFlags);
         }
     }
 
@@ -198,7 +198,7 @@ protected PacketEntry(ByteBuf buf) throws IOException {
     public static class PacketAdd extends PacketEntry {
 
         public String name;
-        public int x, y, z, dim;
+        public int x, y, z, dim, side;
         public int rows, rowSize;
         public boolean online;
         public ItemStack selfRep, dispRep;
@@ -214,11 +214,12 @@ public static class PacketAdd extends PacketEntry {
             super(buf);
         }
 
-        public PacketAdd setLoc(int x, int y, int z, int dim) {
+        public PacketAdd setLoc(int x, int y, int z, int dim, int side) {
             this.x = x;
             this.y = y;
             this.z = z;
             this.dim = dim;
+            this.side = side;
             return this;
         }
 
@@ -252,6 +253,7 @@ protected void write(ByteBuf buf) throws IOException {
             buf.writeInt(y);
             buf.writeInt(z);
             buf.writeInt(dim);
+            buf.writeInt(side);
             buf.writeInt(rows);
             buf.writeInt(rowSize);
 
@@ -284,6 +286,7 @@ protected void read(ByteBuf buf) throws IOException {
             this.y = buf.readInt();
             this.z = buf.readInt();
             this.dim = buf.readInt();
+            this.side = buf.readInt();
             this.rows = buf.readInt();
             this.rowSize = buf.readInt();
             int payloadSize = buf.readInt();