Reduce interface terminal TPS impact + break some backends + new gui #394

firenoo · 2023-09-27T15:47:18Z

~~I really wished the star import refactor was done after this, because now there are merge conflicts...~~ eh wasnt too bad, fixed

This is actually a subset of the features I want to implement.

Backend Changes

Reduce the rate at which server-side changes are polled. Before this was done on every tick, but this has been changed to when changes were detected on either the ME network (i.e. a connection was added) or when the player performs an inventory action.
Deprecate (it's only been like 5 versions lol) the old interface terminal handler. Despite approving the old one, I feel like it could have been done a bit better. This is a breaking change with GT5 and AE2FC.

GUI Changes

Revisited the GUI. I felt like learning OpenGL, and decided to implement a true viewport widget for the interface terminal.
Names of each interface title are pinned at the top.
Shift + scroll = scroll from section to section
Ctrl + scroll = go to top/bottom of the page.

Would like some brave testers to test this. Initial tests seemed fine, but there are probably a ton of corner cases that need to have bugs squashed.

Laiff

Great work! Will try to reuse Packet logic and container. It mostly does not affect my implementation of LMTerm

src/main/java/appeng/client/render/TranslatedRenderItem.java

src/main/java/appeng/core/features/registries/IfaceTermRegistry.java

src/main/java/appeng/core/sync/packets/PacketIfaceTermUpdate.java

src/main/java/appeng/client/gui/implementations/GuiInterfaceTerminal.java

Does two things: * Deprecate old interface terminal support classes. * Refactors the interface terminal API into AEApi. * Changes the API to use only relevant operations. Relevant here means things we will actually use when the packet format is updated in the next few commits. This is a breaking change, but it won't be hard to fix.

The booting/nonbooting event is posted whenever the ME system starts its "boot" phase and when the "boot" phase is finished. This commit distinguishes the two phases. Some subscribers might need this information to determine whether to push an update or not. An example is written in this commit - part interface terminal is only curious about when the terminal boots back up, not when the network enters the booting state.

github-actions · 2023-10-06T16:23:48Z

Warning: 2 uncommitted changes
#400

Laiff · 2023-10-07T14:28:21Z

What about realtime update in interface terminal from other interactions. Like other player put new pattern if interface or other path that valuable in my implementation for Level terminal state has been changed and we need to notify opened gui about this

src/main/java/appeng/core/sync/packets/PacketIfaceTermUpdate.java

src/main/resources/assets/appliedenergistics2/textures/guis/newinterfaceterminal.png

Adds a new packet specifically for updating the entries on the terminal. Reduces network traffic, potentially significantly, as it allows for incremental updates instead of sending a fresh list every time the entries on the list change (Note it WAS smart enough to not send a fresh list if only patterns changed). Deprecates appeng/core/sync/packets/PacketCompressedNBT Commit does not add functionality to handling on the client side yet.

The interface terminal is ripe for many optimizations. This commit seeks to fix the biggest issues: * Every tick, the interface terminal checks for any network changes. This has been improved to check only when the network has finished booting. * Every tick, the interface terminal iterates through all of its tracked inventories to check for changes. This is bad when the ME system has a nontrivial amount of tracked inventories, because it it tries to check whether items are different, and is expensive for NBT items such as patterns. This has been changed to send changes that have been marked dirty. This commit does not implement handling on the GUI side.

appeng/client/render: Render items using translations appeng/client/gui/AEBaseGui: Use custom renderSlot Squash of 2 commits: * Depth test should be allowed to be used when rendering slots to make it easier to support z-level translations rather than use a pass-based rendering system. * This commit disables those depth tests which allows tooltips to be drawn before the rest of the screen is drawn, which makes it way less messy to code as everything can be done in 1 pass. MC's native RenderItem disregards z-level when drawing item overlays, since it disables GL_DEPTH_TEST before drawing it. This commit adds a way for AE2 to draw slots with its own z-level methods.

src/main/java/appeng/container/implementations/ContainerInterfaceTerminal.java

src/main/java/appeng/client/gui/IInterfaceTerminalPostUpdate.java

src/main/java/appeng/core/sync/packets/PacketIfaceTermUpdate.java

firenoo · 2023-10-25T04:24:20Z

I will assign laiff so he will decide when to merge. I dont see too many open issues after the last round of fixes so I assume most of them are good. I would recommend another round of tests for each part of the terminal before merging.
Edit: seems like you've already done it.

Fragile parts are the search components (each text box)

miozune

Textbox rendering looks broken in dev env

src/main/java/appeng/client/gui/implementations/GuiInterfaceTerminal.java

src/main/java/appeng/core/sync/packets/PacketCompressedNBT.java

Laiff · 2023-10-26T09:48:07Z

Textbox rendering looks broken in dev env

What language should be here? I think utf flag somehow lost for this textboxes

miozune · 2023-10-26T09:49:58Z

I typed "yellow"

Laiff · 2023-10-26T09:59:28Z

I typed "yellow"

ok i'll check it

Laiff · 2023-10-26T13:24:17Z

I typed "yellow"

I can't reproduce this behaviour. I tried to enter this in plain english in japan and greek. There are no problem with rendering. Can you clarify what exactly you do to get this strange rendering? And i think it can be splited out into separate
issue

github-actions · 2023-10-26T13:47:03Z

Warning: 2 uncommitted changes
#415

miozune

The issue I raised is

Cannot be reproduced on Laiff's env
Cannot be reproduced on my modpack instance
Cannot be figured out how to fix on my end

So I'd approve this PR. Great work!

OneEyeMaker · 2023-10-27T09:16:10Z

@Laiff Look carefully at Miozune's image. It's not the textbox rendering that's broken; it's the rendering order. Look at counts of items. These numbers are rendered behind items. Also word 'yellow' is correctly rendered (if you check width of characters), but every character have some rectangular overlay.

Laiff · 2023-10-27T09:24:11Z

Look at counts of items

Yes there are few problems fix zIndexes, mainly all of them related to DuraDisplay where Depth test completely disabled for overlays. I'll try to figure out solution but separately after discussing with caedis or someone else

firenoo force-pushed the interface_term_simple branch 6 times, most recently from a441b81 to 248ada6 Compare September 27, 2023 16:18

firenoo marked this pull request as ready for review September 27, 2023 16:58

Laiff reviewed Oct 3, 2023

View reviewed changes

src/main/java/appeng/client/render/TranslatedRenderItem.java Show resolved Hide resolved

src/main/java/appeng/core/features/registries/IfaceTermRegistry.java Outdated Show resolved Hide resolved

Laiff reviewed Oct 5, 2023

View reviewed changes

src/main/java/appeng/core/sync/packets/PacketIfaceTermUpdate.java Outdated Show resolved Hide resolved

Laiff reviewed Oct 5, 2023

View reviewed changes

src/main/java/appeng/core/sync/packets/PacketIfaceTermUpdate.java Outdated Show resolved Hide resolved

Laiff reviewed Oct 6, 2023

View reviewed changes

src/main/java/appeng/client/gui/implementations/GuiInterfaceTerminal.java Show resolved Hide resolved

firenoo added 2 commits October 6, 2023 09:18

firenoo force-pushed the interface_term_simple branch from 248ada6 to f902a46 Compare October 6, 2023 16:18

firenoo self-assigned this Oct 6, 2023

firenoo added the merge by assignee only assignee should merge label Oct 6, 2023

github-actions bot mentioned this pull request Oct 6, 2023

Spotless apply for branch interface_term_simple for #394 #400

Closed

firenoo force-pushed the interface_term_simple branch from f902a46 to 7b1a916 Compare October 6, 2023 16:49

Laiff reviewed Oct 7, 2023

View reviewed changes

src/main/java/appeng/core/sync/packets/PacketIfaceTermUpdate.java Outdated Show resolved Hide resolved

Laiff reviewed Oct 7, 2023

View reviewed changes

src/main/resources/assets/appliedenergistics2/textures/guis/newinterfaceterminal.png Outdated Show resolved Hide resolved

firenoo force-pushed the interface_term_simple branch from 7b1a916 to c71a2e5 Compare October 7, 2023 14:57

firenoo added 4 commits October 7, 2023 08:10

appeng/helpers: Use new iface terminal API

a89f634

Fix TranslatedRenderItem integrate POST_HOOKS to support DuraDisplay

c493a4f

Laiff approved these changes Oct 15, 2023

View reviewed changes

Fix buffer read write inconsistency

0a366d6

firenoo commented Oct 22, 2023

View reviewed changes

src/main/java/appeng/container/implementations/ContainerInterfaceTerminal.java Show resolved Hide resolved

firenoo commented Oct 22, 2023

View reviewed changes

src/main/java/appeng/client/gui/IInterfaceTerminalPostUpdate.java Show resolved Hide resolved

firenoo commented Oct 22, 2023

View reviewed changes

src/main/java/appeng/core/sync/packets/PacketIfaceTermUpdate.java Outdated Show resolved Hide resolved

Laiff assigned Laiff and unassigned firenoo Oct 22, 2023

Laiff added 4 commits October 22, 2023 22:13

Fix zIndexes for compatability with DuraDisplay

ef03195

Use IInterfaceViewable to decide crafting location

eb78532

Fix tooltip zIndex

7fe4981

Replace ForgeDirection serialization with byte

56629f4

This was referenced Oct 24, 2023

shift click in crafting page not highlighting most pattern locations(might be all crib s) GTNewHorizons/GT-New-Horizons-Modpack#14755

Closed

Draconic evolution item render in interface terminal is broken GTNewHorizons/GT-New-Horizons-Modpack#14754

Closed

miozune reviewed Oct 26, 2023

View reviewed changes

src/main/java/appeng/client/gui/implementations/GuiInterfaceTerminal.java Outdated Show resolved Hide resolved

src/main/java/appeng/core/sync/packets/PacketCompressedNBT.java Outdated Show resolved Hide resolved

Laiff requested a review from miozune October 26, 2023 13:46

github-actions bot mentioned this pull request Oct 26, 2023

Spotless apply for branch interface_term_simple for #394 #415

Closed

Code cleanup after review

f35c5af

Laiff force-pushed the interface_term_simple branch from f45a21f to f35c5af Compare October 26, 2023 13:48

miozune approved these changes Oct 27, 2023

View reviewed changes

Dream-Master merged commit 4f25784 into master Oct 27, 2023
1 check passed

Dream-Master deleted the interface_term_simple branch October 27, 2023 11:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce interface terminal TPS impact + break some backends + new gui #394

Reduce interface terminal TPS impact + break some backends + new gui #394

firenoo commented Sep 27, 2023 •

edited

Loading

Laiff left a comment

github-actions bot commented Oct 6, 2023

Laiff commented Oct 7, 2023

firenoo commented Oct 25, 2023 •

edited

Loading

miozune left a comment

Laiff commented Oct 26, 2023

miozune commented Oct 26, 2023

Laiff commented Oct 26, 2023

Laiff commented Oct 26, 2023 •

edited

Loading

github-actions bot commented Oct 26, 2023

miozune left a comment

OneEyeMaker commented Oct 27, 2023 •

edited

Loading

Laiff commented Oct 27, 2023

Reduce interface terminal TPS impact + break some backends + new gui #394

Reduce interface terminal TPS impact + break some backends + new gui #394

Conversation

firenoo commented Sep 27, 2023 • edited Loading

Laiff left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 6, 2023

Laiff commented Oct 7, 2023

firenoo commented Oct 25, 2023 • edited Loading

miozune left a comment

Choose a reason for hiding this comment

Laiff commented Oct 26, 2023

miozune commented Oct 26, 2023

Laiff commented Oct 26, 2023

Laiff commented Oct 26, 2023 • edited Loading

github-actions bot commented Oct 26, 2023

miozune left a comment

Choose a reason for hiding this comment

OneEyeMaker commented Oct 27, 2023 • edited Loading

Laiff commented Oct 27, 2023

firenoo commented Sep 27, 2023 •

edited

Loading

firenoo commented Oct 25, 2023 •

edited

Loading

Laiff commented Oct 26, 2023 •

edited

Loading

OneEyeMaker commented Oct 27, 2023 •

edited

Loading